Date: Thu, 21 Mar 2024 21:13:36 +0100 From: tuexen@freebsd.org To: Dimitry Andric <dim@FreeBSD.org> Cc: current@freebsd.org Subject: Re: Problem with make installworld Message-ID: <5C76C958-3BBB-4887-96C8-84F663AC2D78@freebsd.org> In-Reply-To: <E0A6722B-3181-4A15-BFB5-35DC5113462E@FreeBSD.org> References: <3DCD0639-057D-4BC9-96B7-FDD6F05E6BB5@freebsd.org> <FCD692D8-D0CB-41BE-BE32-FE6A0EFC5BD4@FreeBSD.org> <CAE7A33A-1D29-440E-B962-30793E65E4FC@freebsd.org> <E0A6722B-3181-4A15-BFB5-35DC5113462E@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 21. Mar 2024, at 18:12, Dimitry Andric <dim@FreeBSD.org> wrote:
>=20
> On 21 Mar 2024, at 01:12, tuexen@freebsd.org wrote:
>>=20
>>> On 21. Mar 2024, at 00:27, Dimitry Andric <dim@FreeBSD.org> wrote:
>>>=20
>>> On 20 Mar 2024, at 21:44, tuexen@freebsd.org wrote:
>>>>=20
>>>> I'm trying to run make buildworld / make installworld on a recent =
main branch
>>>> (some days old).
>>>>=20
>>>> The problem is related to lib/libc/tests/ssp/Makefile
>>>> which contains:
>>>> _libclang_rt_ubsan=3D =
${SYSROOT}${SANITIZER_LIBDIR}/libclang_rt.ubsan_standalone-${CRTARCH}.a
>>>> if exists(${_libclang_rt_ubsan})
>>>> PROGS+=3D h_raw
>>>> LDADD.h_raw+=3D ${SANITIZER_LDFLAGS}
>>>>=20
>>>> When running make buildworld, we have
>>>> ${SYSROOT} =3D =
/usr/obj/usr/home/tuexen/freebsd-src/powerpc.powerpc64/tmp
>>>> ${SANITIZER_LIBDIR} =3D /usr/lib/clang/17/lib/freebsd
>>>> and so the script is looking for
>>>> =
/usr/obj/usr/home/tuexen/freebsd-src/powerpc.powerpc64/tmp/usr/lib/clang/1=
7/lib/freebsd/libclang_rt.ubsan_standalone-powerpc64.a
>>>> which does not exist:
>>>> tuexen@blackbird:~ % ls -l =
/usr/obj/usr/home/tuexen/freebsd-src/powerpc.powerpc64/tmp/usr/lib/clang/1=
7/lib/freebsd/
>>>> total 652
>>>> -r--r--r-- 1 root wheel 284316 Mar 20 18:03 =
libclang_rt.profile-powerpc.a
>>>> -r--r--r-- 1 root wheel 380704 Mar 20 17:41 =
libclang_rt.profile-powerpc64.a
>>>>=20
>>>> Therefore, h_raw to NOT built.
>>>=20
>>> As far as I can see, for powerpc64 it should have been built =
somewhere during the libraries stage. So it's a bit strange that you =
don't have the file. Did you use any special options to build?
>> No, not any I'm aware of. I can run tests or provide further =
information.
>=20
> This was my mistake: I recently refactored lib/libclang_rt/Makefile to =
make it more readable and maintainable, but it accidentally broke =
building of most of the libclang_rt*.a files for powerpc64. It should =
now be fixed by https://cgit.freebsd.org/src/commit/?id=3Df0620ceeccf0 .
Hi Dimitry,
I tested the main branch with your fix and I can confirm that the
problem is fixed.
Thank you very much for the quick fix!
Best regards
Michael
>=20
> -Dimitry
>=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5C76C958-3BBB-4887-96C8-84F663AC2D78>