Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 15 Dec 1996 23:43:25 +1100
From:      Bruce Evans <bde@zeta.org.au>
To:        bde@zeta.org.au, peter@spinner.DIALix.COM
Cc:        cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, nate@mt.sri.com
Subject:   Re: cvs commit: src/sys/i386/boot/rawboot Makefile
Message-ID:  <199612151243.XAA03824@godzilla.zeta.org.au>

index | next in thread | raw e-mail

>My complaint is that they are hidden under i386/isa/ic/* making access to 
>them rather difficult.  There is nothing isa-specific about the i8042.h 
>file, except the two IO port control/data addresses (which are duplicated 
>from isa.h).  IMHO, the "chip defines" should have gone under 
>i386/include/ic so they could be accessable as #include 
><machine/ic/i8042.h> without having to obsuscate the code with -I paths or 
>bogus #include lines.

They shouldn't go in i386/include either.  There's nothing i386-specific
about them.

NetBSD now has them in in /sys/dev/ic.  I might prefer /sys/ic.  i8042.h
got renamed to i8042reg.h.  I don't like this.  An `ic' may have more
attributes than registers - it may have an instruction set..., and if
you think of registers as being their bus addresses, then the registers
aren't part of the ic.

Bruce


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199612151243.XAA03824>