From owner-svn-src-all@freebsd.org Fri Jan 18 22:54:39 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37F4E14863DF; Fri, 18 Jan 2019 22:54:39 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AD33080765; Fri, 18 Jan 2019 22:54:38 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x0IMsY90057816; Fri, 18 Jan 2019 14:54:35 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x0IMsYYW057815; Fri, 18 Jan 2019 14:54:34 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201901182254.x0IMsYYW057815@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r343152 - head/usr.sbin/freebsd-update In-Reply-To: To: Ed Maste Date: Fri, 18 Jan 2019 14:54:34 -0800 (PST) CC: "Rodney W. Grimes" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: AD33080765 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2019 22:54:39 -0000 > On Fri, 18 Jan 2019 at 12:51, Rodney W. Grimes > wrote: > > > > Since your in here fixing... there is a false positive on the > > detection of what is installed when we zero the size of a set, > > ie, now that doc.txz is a 0 size set it always thinks you have > > doc installed due to rounding errors in the calculation that > > says you have x% of this installed. > > Hi Rod, I'm not sure exactly what you mean here - could you clarify, > or create a PR with the details? During the 12.0 release cycle the doc.txz part of the system went away, we put up an empty tar ball, when freebsd-update evaluates if you have installed this component it says you have, even though you have not. This is caused by function: upgrade_guess_components () { when it does this: join -t ' ' -1 2 -2 2 compfreq.present compfreq.total | while read S P T; do if [ ${P} -gt `expr ${T} / 2` ]; then echo ${S} fi done > comp.present When expr ${T} the count of items in the set is 0 all things are -gt 0 and so it says the component is present. This is an incorrect false positive. > > -- Rod Grimes rgrimes@freebsd.org