From owner-svn-src-head@FreeBSD.ORG Fri May 29 16:49:45 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7608210656C3; Fri, 29 May 2009 16:49:45 +0000 (UTC) (envelope-from trasz@FreeBSD.org) Received: from pin.if.uz.zgora.pl (pin.if.uz.zgora.pl [212.109.128.251]) by mx1.freebsd.org (Postfix) with ESMTP id 342138FC0C; Fri, 29 May 2009 16:49:45 +0000 (UTC) (envelope-from trasz@FreeBSD.org) Received: by pin.if.uz.zgora.pl (Postfix, from userid 1001) id 3B14F39BA2; Fri, 29 May 2009 18:38:00 +0200 (CEST) Date: Fri, 29 May 2009 18:38:00 +0200 From: Edward Tomasz Napierala To: Scott Long Message-ID: <20090529163800.GA80773@pin.if.uz.zgora.pl> References: <200905291500.n4TF04HM078212@svn.freebsd.org> <4A2003D4.2010607@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline In-Reply-To: <4A2003D4.2010607@samsco.org> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r193041 - head/sys/sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2009 16:49:46 -0000 On 0529T0948, Scott Long wrote: > Occasionally it's useful to be able to run older binaries on newer > kernels. Yes, not being able to use mount(8) from FreeBSD 7 on a kernel from FreeBSD 8 would suck. ;-) > One particularly useful place is for making releases. Does > this change to struct mount break that? If so, could there be any other > way to achieve what you want without the breakage? No, it doesn't break it. Also, I think breaking ABI for mount(8) because of mount flags won't be neccessary anytime soon - for mounting and unmounting we have nmount(2), which is extensible by definition, and to display mounted filesystems, mount(8) uses statfs(2), and f_flags is int64_t already. > Edward Tomasz Napierala wrote: > > Author: trasz > > Date: Fri May 29 15:00:04 2009 > > New Revision: 193041 > > URL: http://svn.freebsd.org/changeset/base/193041 > > > > Log: > > There is only one spare MNT_ flag left, and I want to use it for NFSv4 ACLs. > > Make room for additional filesystem flags now, to avoid breaking ABI later. > > > > Reviewed by: kib@ > > > > Modified: > > head/sys/sys/mount.h > > > > Modified: head/sys/sys/mount.h > > ============================================================================== > > --- head/sys/sys/mount.h Fri May 29 14:42:02 2009 (r193040) > > +++ head/sys/sys/mount.h Fri May 29 15:00:04 2009 (r193041) > > @@ -167,6 +167,7 @@ struct mount { > > int mnt_writeopcount; /* (i) write syscalls pending */ > > int mnt_kern_flag; /* (i) kernel only flags */ > > u_int mnt_flag; /* (i) flags shared with user */ > > + u_int mnt_xflag; /* (i) more flags shared with user */ > > u_int mnt_noasync; /* (i) # noasync overrides */ > > struct vfsoptlist *mnt_opt; /* current mount options */ > > struct vfsoptlist *mnt_optnew; /* new options passed to fs */ > > @@ -221,7 +222,7 @@ void __mnt_vnode_markerfree(str > > #endif /* _KERNEL */ > > > > /* > > - * User specifiable flags. > > + * User specifiable flags, stored in mnt_flag. > > */ > > #define MNT_RDONLY 0x00000001 /* read only filesystem */ > > #define MNT_SYNCHRONOUS 0x00000002 /* filesystem written synchronously */ > -- If you cut off my head, what would I say? Me and my head, or me and my body?