From owner-freebsd-usb@FreeBSD.ORG Fri Jan 27 04:40:05 2006 Return-Path: X-Original-To: freebsd-usb@hub.freebsd.org Delivered-To: freebsd-usb@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B4F5616A420 for ; Fri, 27 Jan 2006 04:40:05 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A90C43D4C for ; Fri, 27 Jan 2006 04:40:04 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k0R4e4bn083227 for ; Fri, 27 Jan 2006 04:40:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k0R4e4ew083226; Fri, 27 Jan 2006 04:40:04 GMT (envelope-from gnats) Resent-Date: Fri, 27 Jan 2006 04:40:04 GMT Resent-Message-Id: <200601270440.k0R4e4ew083226@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-usb@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Marcin Gryszkalis Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA12416A422 for ; Fri, 27 Jan 2006 04:36:47 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 780D743D48 for ; Fri, 27 Jan 2006 04:36:47 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k0R4ak9m097365 for ; Fri, 27 Jan 2006 04:36:46 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k0R4akoZ097364; Fri, 27 Jan 2006 04:36:46 GMT (envelope-from nobody) Message-Id: <200601270436.k0R4akoZ097364@www.freebsd.org> Date: Fri, 27 Jan 2006 04:36:46 GMT From: Marcin Gryszkalis To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: usb/92403: uplcom.c needs new entry for 4.00 revision of Prolific chipset X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2006 04:40:05 -0000 >Number: 92403 >Category: usb >Synopsis: uplcom.c needs new entry for 4.00 revision of Prolific chipset >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-usb >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jan 27 04:40:03 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Marcin Gryszkalis >Release: 6.0-STABLE >Organization: fork.pl >Environment: >Description: uplcom.c driver tries to recognize PL2303 chips from PL2303X - unfortunately both can have same product and vendor id. It seems that for USB_VENDOR_PROLIFIC and USB_PRODUCT_PROLIFIC_PL2303 any version >= 3 is PL2303X but the code checks for exact value (0x300). I have an adapter that introduces itself as 4.00 revision. ucom0: Prolific Technology Inc. USB-Serial Controller C, rev 1.10/4.00, addr 2 # usbdevs -v | grep Pro port 1 addr 2: full speed, power 100 mA, config 1, USB-Serial Controller C(0x2303), Prolific Technology Inc.(0x067b), rev 4.00 Quick patch I made (see below) works well but I think some more generic solution is required (It's not fun to add such lines again and again with 4.10, 5.00 revisions if they appear someday). The patch is against uplcom.c 1.30. >How-To-Repeat: >Fix: --- uplcom-latest.c Fri Jan 27 05:20:35 2006 +++ uplcom.c Fri Jan 27 05:13:53 2006 @@ -238,6 +238,8 @@ /* ST Lab USB-SERIAL-4 */ { USB_VENDOR_PROLIFIC, USB_PRODUCT_PROLIFIC_PL2303, 0x300, TYPE_PL2303X }, + { USB_VENDOR_PROLIFIC, USB_PRODUCT_PROLIFIC_PL2303, + 0x400, TYPE_PL2303X }, /* IOGEAR/ATEN UC-232A (also ST Lab USB-SERIAL-1) */ { USB_VENDOR_PROLIFIC, USB_PRODUCT_PROLIFIC_PL2303, -1, TYPE_PL2303 }, /* TDK USB-PHS Adapter UHA6400 */ >Release-Note: >Audit-Trail: >Unformatted: