From owner-svn-src-head@FreeBSD.ORG  Sat May 23 16:09:31 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A02B7106564A;
	Sat, 23 May 2009 16:09:31 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 7A4388FC19;
	Sat, 23 May 2009 16:09:31 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [65.122.17.41])
	by cyrus.watson.org (Postfix) with ESMTPS id EB4EB46B4C;
	Sat, 23 May 2009 12:09:30 -0400 (EDT)
Date: Sat, 23 May 2009 17:09:30 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Dag-Erling Smorgrav <des@FreeBSD.org>
In-Reply-To: <200905231600.n4NG0G78059747@svn.freebsd.org>
Message-ID: <alpine.BSF.2.00.0905231708290.75344@fledge.watson.org>
References: <200905231600.n4NG0G78059747@svn.freebsd.org>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r192639 - head/sys/cddl/boot/zfs
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 May 2009 16:09:32 -0000

On Sat, 23 May 2009, Dag-Erling Smorgrav wrote:

>  Remove svn:keywords on a file that had fbsd:nokeywords (though I don't
>  understand the reason for the latter)

This seems backwards, as does the commit that followed it to remove the 
expanded $FreeBSD$ string.  Is there any reason this file shouldn't have an ID 
string?  Or rather, is there any reason to have an unexpanded one as opposed 
to none, or an expanded one?

Robert N M Watson
Computer Laboratory
University of Cambridge

>
> Modified:
>  head/sys/cddl/boot/zfs/zfssubr.c   (contents, props changed)
>
> Modified: head/sys/cddl/boot/zfs/zfssubr.c
> ==============================================================================
> --- head/sys/cddl/boot/zfs/zfssubr.c	Sat May 23 13:51:05 2009	(r192638)
> +++ head/sys/cddl/boot/zfs/zfssubr.c	Sat May 23 16:00:16 2009	(r192639)
> @@ -24,7 +24,7 @@
>  */
>
> #include <sys/cdefs.h>
> -__FBSDID("$FreeBSD$");
> +__FBSDID("$FreeBSD: head/sys/cddl/boot/zfs/zfssubr.c 192599 2009-05-22 20:07:39Z des $");
>
> static uint64_t zfs_crc64_table[256];
>
>