From owner-freebsd-ports  Sun Mar 16  3:55:32 2003
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CADF937B405
	for <ports@freebsd.org>; Sun, 16 Mar 2003 03:55:30 -0800 (PST)
Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at [128.131.111.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 875A743FBF
	for <ports@freebsd.org>; Sun, 16 Mar 2003 03:55:28 -0800 (PST)
	(envelope-from pfeifer@dbai.tuwien.ac.at)
Received: from [128.131.111.52] (naos [128.131.111.52])
	by vexpert.dbai.tuwien.ac.at (8.12.8/8.12.8) with ESMTP id h2GBtRxi001516
	for <ports@freebsd.org>; Sun, 16 Mar 2003 12:55:27 +0100 (CET)
Date: Sun, 16 Mar 2003 12:55:25 +0100 (CET)
From: Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>
To: ports@freebsd.org
Subject: ports/Mk/bsd.port.mk -- installing ports as non-root
Message-ID: <Pine.BSF.4.51.0303161246490.43104@naos.dbai.tuwien.ac.at>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org

In ports/Mk/bsd.port.mk we have

  # Determine whether or not we can use rootly owner/group functions.
  UID!=   id -u
  .if ${UID} == 0
  _BINOWNGRP=     -o ${BINOWN} -g ${BINGRP}
  _SHROWNGRP=     -o ${SHAREOWN} -g ${SHAREGRP}
  _MANOWNGRP=     -o ${MANOWN} -g ${MANGRP}
  .else
  _BINOWNGRP=
  _SHROWNGRP=
  _MANOWNGRP=
  .endif

which are then used as follows

  # A few aliases for *-install targets
  INSTALL_PROGRAM= \
        ${INSTALL} ${COPY} ${STRIP} ${_BINOWNGRP} -m ${BINMODE}
  INSTALL_SCRIPT= \
        ${INSTALL} ${COPY} ${_BINOWNGRP} -m ${BINMODE}
  INSTALL_DATA= \
        ${INSTALL} ${COPY} ${_SHROWNGRP} -m ${SHAREMODE}
  INSTALL_MAN= \
        ${INSTALL} ${COPY} ${_MANOWNGRP} -m ${MANMODE}

However, in one case this is not honored and a chown is tried even when
not running is root.

The patch below tries to address this; or did I miss anything?

Gerald (@FreeBSD.org)

Index: bsd.port.mk
===================================================================
RCS file: /sw/FreeBSD/CVSUP/ports/Mk/bsd.port.mk,v
retrieving revision 1.442
diff -u -3 -p -r1.442 bsd.port.mk
--- bsd.port.mk	12 Mar 2003 00:28:17 -0000	1.442
+++ bsd.port.mk	16 Mar 2003 11:43:49 -0000
@@ -2701,7 +2701,7 @@ do-configure:
 	@(cd ${CONFIGURE_WRKSRC} && \
 		if ! ${SETENV} CC="${CC}" CXX="${CXX}" \
 	    CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}" \
-	    INSTALL="/usr/bin/install -c -o ${BINOWN} -g ${BINGRP}" \
+	    INSTALL="/usr/bin/install -c ${_BINOWNGRP}" \
 	    INSTALL_DATA="${INSTALL_DATA}" \
 	    INSTALL_PROGRAM="${INSTALL_PROGRAM}" \
 	    INSTALL_SCRIPT="${INSTALL_SCRIPT}" \

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message