From owner-freebsd-python@FreeBSD.ORG Tue Jun 17 12:24:19 2014 Return-Path: Delivered-To: freebsd-python@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 70B4B9CD for ; Tue, 17 Jun 2014 12:24:19 +0000 (UTC) Received: from smtprelay02.ispgateway.de (smtprelay02.ispgateway.de [80.67.31.29]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2D07A29A4 for ; Tue, 17 Jun 2014 12:24:18 +0000 (UTC) Received: from [80.67.16.121] (helo=webmailfront01.ispgateway.de) by smtprelay02.ispgateway.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1WwsKF-000591-S0 for freebsd-python@freebsd.org; Tue, 17 Jun 2014 14:17:19 +0200 Received: from his1.his.de (his1.his.de [192.124.237.237]) by webmail.df.eu (Horde Framework) with HTTP; Tue, 17 Jun 2014 14:17:19 +0200 Date: Tue, 17 Jun 2014 14:17:19 +0200 Message-ID: <20140617141719.Horde.bY9jQiZwT232o0HYSxD0_w5@webmail.df.eu> From: Marcus von Appen To: freebsd-python@freebsd.org Subject: Re: Python 2.7.7 References: <20140617132216.Horde.Lce6wqtFBWF13HgfAJ18Sg1@webmail.df.eu> <53A027BD.2030203@FreeBSD.org> In-Reply-To: <53A027BD.2030203@FreeBSD.org> Reply-to: mva@freebsd.org User-Agent: Internet Messaging Program (IMP) H5 (6.0.4) Content-Type: text/plain; charset=UTF-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-Df-Sender: ZnJlZWJzZEBzeXNmYXVsdC5vcmc= X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jun 2014 12:24:19 -0000 Kubilay Kocak : > On 17/06/2014 9:22 PM, Marcus von Appen wrote: >> Li-Wen Hsu : >> >>> On Wed, Jun 11, 2014 at 1:54 AM, Robert Simmons >>> wrote: >>>> Is there an ETA for updating the python27 port to 2.7.7? >>> >>> I just made a patch for updating python27: >>> >>> https://people.freebsd.org/~lwhsu/patch/python-2.7.7.diff >> >> lang/python27/files/patch-Lib__distutils__unixccompiler.py should be kept. >> http://bugs.python.org/issue20767 has not been closed yet and the 2.7.7 >> source >> code does not incorporate the change nor does the NEWS file indicate >> anything related >> to the issue. >> >> I'm also unsure about the fcntl.ioctl() patch change. The 2.7.6 patch >> used an >> unsigned long on purpose, since we are not limited to 32 bit. The 2.7.7 >> patch however >> seems to revert this behaviour, limiting ioctl() to 32 bit, which will >> most likely >> have an impact on ports using ioctl(). I can't find a related python >> issue - did we >> ever report our change upstream? >> >> Cheers >> Marcus >> >> _______________________________________________ >> freebsd-python@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-python >> To unsubscribe, send any mail to "freebsd-python-unsubscribe@freebsd.org" > > I don't recall coming across one, but I could be wrong. > > If I understood the change (and its background/context), I'd upstream it > in a heartbeat given its simplicity. > > Is the change conditional on FreeBSD? What might be required to get it > upstream ready? > All hail to the revision logs: http://svnweb.freebsd.org/ports?view=revision&revision=257978 Fix fcntl module to accept 'unsigned long' type commands for ioctl(2). Although POSIX says the type is 'int', all BSD variants (including Mac OS X) have been using 'unsigned long' type for very long time and its use predates the standard long enough. For certain commands (e.g., TIOCSWINSZ, FIONBIO), the Python value may get sign-extended on 64-bit platforms (by implicit type promotion) and it causes annoying warnings from kernel such as this: WARNING pid 24509 (python2.6): ioctl sign-extension ioctl ffffffff8004667e -- cut here for more fun -- Cheers Marcus