From owner-svn-src-all@FreeBSD.ORG  Sat Jul 24 18:37:38 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 14E70106564A;
	Sat, 24 Jul 2010 18:37:38 +0000 (UTC)
	(envelope-from stefan@fafoe.narf.at)
Received: from fep17.mx.upcmail.net (fep17.mx.upcmail.net [62.179.121.37])
	by mx1.freebsd.org (Postfix) with ESMTP id 1AA428FC1B;
	Sat, 24 Jul 2010 18:37:36 +0000 (UTC)
Received: from edge02.upcmail.net ([192.168.13.237]) by viefep17-int.chello.at
	(InterMail vM.8.01.02.02 201-2260-120-106-20100312) with ESMTP
	id <20100724183734.XNEW21441.viefep17-int.chello.at@edge02.upcmail.net>;
	Sat, 24 Jul 2010 20:37:34 +0200
Received: from mole.fafoe.narf.at ([213.47.85.26])
	by edge02.upcmail.net with edge
	id ludZ1e03X0a5KZh02udaDi; Sat, 24 Jul 2010 20:37:34 +0200
X-SourceIP: 213.47.85.26
Received: by mole.fafoe.narf.at (Postfix, from userid 1001)
	id 6459C6D438; Sat, 24 Jul 2010 20:37:33 +0200 (CEST)
Date: Sat, 24 Jul 2010 20:37:33 +0200
From: Stefan Farfeleder <stefanf@FreeBSD.org>
To: Konstantin Belousov <kib@FreeBSD.org>
Message-ID: <20100724183732.GA1715@mole.fafoe.narf.at>
References: <201007241814.o6OIEY4K099556@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201007241814.o6OIEY4K099556@svn.freebsd.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-Cloudmark-Analysis: v=1.1 cv=BX1z5e3lS7RAKjOkUI/uDpZ/pP4xz0N/VImyOZX9Sfk=
	c=1 sm=0 a=nrf5MxZtRN4A:10 a=kj9zAlcOel0A:10 a=6I5d2MoRAAAA:8
	a=fI0r-MSKK3sSlLGpg0QA:9 a=LcR1EV5zY5gGp4-98foA:7
	a=zPXc5WPT3aArrnPa4H3_Ly-u_U8A:4 a=CjuIK1q_8ugA:10
	a=HpAAvcLHHh0Zw7uRqdWCyQ==:117
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r210451 - head/sys/sys
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Jul 2010 18:37:38 -0000

Hi Konstantin,

declaring enums like this is not standard C code (seems to be a GCC
extension). I don't think we should use this feature in our headers.

Stefan

On Sat, Jul 24, 2010 at 06:14:34PM +0000, Konstantin Belousov wrote:
> Author: kib
> Date: Sat Jul 24 18:14:34 2010
> New Revision: 210451
> URL: http://svn.freebsd.org/changeset/base/210451
> 
> Log:
>   Use forward declartion for enum uio_seg in imgact.h. This allows to remove
>   inclusion of sys/uio.h from the header.
>   
>   Proposed by:	alc
>   MFC after:	1 week
> 
> Modified:
>   head/sys/sys/imgact.h
> 
> Modified: head/sys/sys/imgact.h
> ==============================================================================
> --- head/sys/sys/imgact.h	Sat Jul 24 18:05:10 2010	(r210450)
> +++ head/sys/sys/imgact.h	Sat Jul 24 18:14:34 2010	(r210451)
> @@ -32,8 +32,6 @@
>  #ifndef _SYS_IMGACT_H_
>  #define	_SYS_IMGACT_H_
>  
> -#include <sys/uio.h>
> -
>  #define MAXSHELLCMDLEN	PAGE_SIZE
>  
>  struct image_args {
> @@ -75,6 +73,7 @@ struct image_params {
>  #ifdef _KERNEL
>  struct sysentvec;
>  struct thread;
> +enum uio_seg;
>  
>  #define IMGACT_CORE_COMPRESS	0x01
>  
>