Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 2 Nov 2018 16:49:00 +0200
From:      Andriy Gapon <avg@FreeBSD.org>
To:        Brooks Davis <brooks@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r340055 - in head: share/man/man9 sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/fs/ext2fs sys/fs/fuse sys/fs/nandfs sys/fs/nfs sys/fs/nfsclient sys/fs/tmpfs sys/kern sys/sys sys/uf...
Message-ID:  <bd1ae18c-a899-e290-8911-06e27f49448e@FreeBSD.org>
In-Reply-To: <201811021442.wA2EgbVc062099@repo.freebsd.org>
References:  <201811021442.wA2EgbVc062099@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 02/11/2018 16:42, Brooks Davis wrote:
> Author: brooks
> Date: Fri Nov  2 14:42:36 2018
> New Revision: 340055
> URL: https://svnweb.freebsd.org/changeset/base/340055
> 
> Log:
>   Make vop_symlink take a const target path.
>   
>   This will enable callers to take const paths as part of syscall
>   decleration improvements.
>   
>   Where doing so is easy and non-distruptive carry the const through
>   implementations. In UFS the value is passed to an interface that must
>   take non-const values. In ZFS, const poisoning would touch code shared
>   with upstream and it's not worth adding diffs.

zfs_vnops.c is already sufficiently different from upstream (because of quite
different VFS models), so a small difference in zfs_symlink's signature would
not be too bad.

>   Bump __FreeBSD_version for external API consumers.
>   
>   Reviewed by:	kib (prior version)
>   Obtained from:	CheriBSD
>   Sponsored by:	DARPA, AFRL
>   Differential Revision:	https://reviews.freebsd.org/D17805
> 
> Modified:
>   head/share/man/man9/VOP_CREATE.9
>   head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c


-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bd1ae18c-a899-e290-8911-06e27f49448e>