From owner-freebsd-threads@FreeBSD.ORG Sun Mar 21 16:56:27 2004 Return-Path: Delivered-To: freebsd-threads@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2CAF216A4CE; Sun, 21 Mar 2004 16:56:27 -0800 (PST) Received: from sccrmhc13.comcast.net (sccrmhc13.comcast.net [204.127.202.64]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA2EC43D2F; Sun, 21 Mar 2004 16:56:26 -0800 (PST) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (sccrmhc13) with ESMTP id <2004032200562501600a7s0oe>; Mon, 22 Mar 2004 00:56:25 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id QAA27085; Sun, 21 Mar 2004 16:56:36 -0800 (PST) Date: Sun, 21 Mar 2004 16:56:35 -0800 (PST) From: Julian Elischer To: Scott Long In-Reply-To: <20040321154513.Q30715@pooker.samsco.home> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: threads@freebsd.org Subject: Re: Who can commit this.. kse vs ULE X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2004 00:56:27 -0000 On Sun, 21 Mar 2004, Scott Long wrote: > > This is a qualitative statement. What exactly is the problem, on a > technical level? This is how it was described to me.. Obrien just committedit.. > > Scott > > On Sun, 21 Mar 2004, Julian Elischer wrote: > > > ULE makes KSE threaded processes slow, unresposive and soemtimes > > unusably so. > > > > On Sun, 21 Mar 2004, Scott Long wrote: > > > > > Thanks. What is the problem that is referred to in the email? This > > > patch looks to be a hack. > > > > > > Scott > > > > > > Julian Elischer wrote: > > > > Scott here's the patch I mentioned... > > > > ---------- Forwarded message ---------- > > > > Date: Wed, 17 Mar 2004 18:30:45 -0800 > > > > From: David O'Brien > > > > To: Taku YAMAMOTO > > > > Cc: freebsd-current@freebsd.org > > > > Subject: Re: [PATCH] for SCHED_ULE & libpthread issue (was Re: I like > > > > > > > > SCHED_4BSD) > > > > > > > > On Fri, Mar 12, 2004 at 09:23:47AM +0900, Taku YAMAMOTO wrote: > > > > > > > >>Until the problem is fully addressed, I will propose following patch > > > >>to be applied. (the least intrusive one attached in the former message) > > > > > > > > > > > > Do people think we should commit this? > > > > > > > > --- sched_ule.c.orig Fri Feb 13 05:24:48 2004 > > > > +++ sched_ule.c Fri Feb 13 05:37:53 2004 > > > > @@ -186,7 +186,7 @@ > > > > #define SCHED_INTERACTIVE(kg) \ > > > > (sched_interact_score(kg) < SCHED_INTERACT_THRESH) > > > > #define SCHED_CURR(kg, ke) \ > > > > - (ke->ke_thread->td_priority != kg->kg_user_pri || \ > > > > + (ke->ke_thread->td_priority < kg->kg_user_pri || \ > > > > SCHED_INTERACTIVE(kg)) > > > > > > > > /* > > > > @@ -1166,11 +1166,8 @@ > > > > */ > > > > if ((ke->ke_flags & KEF_ASSIGNED) == 0) { > > > > if (TD_IS_RUNNING(td)) { > > > > - if (td->td_proc->p_flag & P_SA) { > > > > - kseq_load_rem(KSEQ_CPU(ke->ke_cpu), ke); > > > > - setrunqueue(td); > > > > - } else > > > > - kseq_runq_add(KSEQ_SELF(), ke); > > > > + kseq_load_rem(KSEQ_CPU(ke->ke_cpu), ke); > > > > + setrunqueue(td); > > > > _______________________________________________ > > > > freebsd-current@freebsd.org mailing list > > > > http://lists.freebsd.org/mailman/listinfo/freebsd-current > > > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > > > > > > > > > > > > > > > > > > > > > > >