Date: Sun, 18 Jun 2006 16:59:19 GMT From: "Christian S.J. Peron" <csjp@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 99535 for review Message-ID: <200606181659.k5IGxJWB036806@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=99535 Change 99535 by csjp@csjp_rnd01 on 2006/06/18 16:59:05 Use bus_get_dma_tag(9) to initialize the parent instead of using NULL. This fixes a null pointer dereference and allows the bge(4) devices to be attached to the system properly. Affected files ... .. //depot/projects/kmacy_sun4v/src/sys/dev/bge/if_bge.c#6 edit Differences ... ==== //depot/projects/kmacy_sun4v/src/sys/dev/bge/if_bge.c#6 (text+ko) ==== @@ -1726,7 +1726,7 @@ /* * Allocate the parent bus DMA tag appropriate for PCI. */ - error = bus_dma_tag_create(NULL, /* parent */ + error = bus_dma_tag_create(bus_get_dma_tag(sc->bge_dev),/* parent */ PAGE_SIZE, 0, /* alignment, boundary */ BUS_SPACE_MAXADDR, /* lowaddr */ BUS_SPACE_MAXADDR, /* highaddr */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200606181659.k5IGxJWB036806>