From owner-p4-projects@FreeBSD.ORG Sun Jun 18 16:59:20 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 3227416A47C; Sun, 18 Jun 2006 16:59:20 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CF26016A47A for ; Sun, 18 Jun 2006 16:59:19 +0000 (UTC) (envelope-from csjp@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9E26A43D45 for ; Sun, 18 Jun 2006 16:59:19 +0000 (GMT) (envelope-from csjp@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k5IGxJsT036809 for ; Sun, 18 Jun 2006 16:59:19 GMT (envelope-from csjp@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k5IGxJWB036806 for perforce@freebsd.org; Sun, 18 Jun 2006 16:59:19 GMT (envelope-from csjp@freebsd.org) Date: Sun, 18 Jun 2006 16:59:19 GMT Message-Id: <200606181659.k5IGxJWB036806@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to csjp@freebsd.org using -f From: "Christian S.J. Peron" To: Perforce Change Reviews Cc: Subject: PERFORCE change 99535 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2006 16:59:20 -0000 http://perforce.freebsd.org/chv.cgi?CH=99535 Change 99535 by csjp@csjp_rnd01 on 2006/06/18 16:59:05 Use bus_get_dma_tag(9) to initialize the parent instead of using NULL. This fixes a null pointer dereference and allows the bge(4) devices to be attached to the system properly. Affected files ... .. //depot/projects/kmacy_sun4v/src/sys/dev/bge/if_bge.c#6 edit Differences ... ==== //depot/projects/kmacy_sun4v/src/sys/dev/bge/if_bge.c#6 (text+ko) ==== @@ -1726,7 +1726,7 @@ /* * Allocate the parent bus DMA tag appropriate for PCI. */ - error = bus_dma_tag_create(NULL, /* parent */ + error = bus_dma_tag_create(bus_get_dma_tag(sc->bge_dev),/* parent */ PAGE_SIZE, 0, /* alignment, boundary */ BUS_SPACE_MAXADDR, /* lowaddr */ BUS_SPACE_MAXADDR, /* highaddr */