From owner-freebsd-ports  Sat Jun 10 22:20:23 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id E892F37BEE4
	for <freebsd-ports@FreeBSD.org>; Sat, 10 Jun 2000 22:20:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id WAA30278;
	Sat, 10 Jun 2000 22:20:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from bsa-1-as01-7-a04.gd.uol.com.br (bsa-1-as01-7-a04.gd.uol.com.br [200.197.118.4])
	by hub.freebsd.org (Postfix) with ESMTP id 860A137BECE
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 10 Jun 2000 22:10:48 -0700 (PDT)
	(envelope-from lioux@uol.com.br)
Received: (qmail 74838 invoked by uid 1001); 11 Jun 2000 05:11:06 -0000
Message-Id: <20000611051106.74837.qmail@Fedaykin.here>
Date: 11 Jun 2000 05:11:06 -0000
From: lioux@uol.com.br
Reply-To: lioux@uol.com.br
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: ports/19193: Update textproc/jade to C{XX,}FLAGS safe status
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         19193
>Category:       ports
>Synopsis:       Update textproc/jade to C{XX,}FLAGS safe status
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 10 22:20:01 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Mario Sergio Fujikawa Ferreira
>Release:        FreeBSD 4.0-STABLE i386
>Organization:
>Environment:

FreeBSD Here.here 4.0-STABLE FreeBSD 4.0-STABLE #2: Fri Jun  9 13:22:10 EST 2000     lioux@Here.here:/usr/src/sys/compile/LIOUX  i386

>Description:

Updated textproc/jade to C{XX,}FLAGS safe status.
Files removed:
	patches/patch-aa

patch-aa is not necessary. "-O" is the default value for C{XX,}FLAGS.
I've just built jade 2 times using very weird C{XX,}FLAGS values
to be sure and it seems okay.

Besides, CONFIGURE_ENV is unusual. Just let CXXFLAGS be CXXFLAGS,
if the user has not set it, we do not unless it brakes the port
not to. This way we respect make.conf choices and behave safely in
possibly hostile enviroments (archs such as alpha).

jade behaves just fine without these

>How-To-Repeat:

n/a

>Fix:

diff -ruN /usr/ports/textproc/jade/Makefile jade/Makefile
--- /usr/ports/textproc/jade/Makefile	Sun Jun 11 01:43:34 2000
+++ jade/Makefile	Sun Jun 11 02:03:53 2000
@@ -23,7 +23,6 @@
 USE_GMAKE=	YES
 USE_LIBTOOL=	YES
 GNU_CONFIGURE=	yes
-CONFIGURE_ENV=	CXXFLAGS="${CFLAGS}"
 CONFIGURE_ARGS=	--enable-default-catalog=${PREFIX}/share/sgml/catalog
 
 post-extract:
diff -ruN /usr/ports/textproc/jade/patches/patch-aa jade/patches/patch-aa
--- /usr/ports/textproc/jade/patches/patch-aa	Mon Dec 27 02:32:51 1999
+++ jade/patches/patch-aa	Wed Dec 31 21:00:00 1969
@@ -1,13 +0,0 @@
---- Makefile.comm.in.orig	Sun Dec 12 21:06:43 1999
-+++ Makefile.comm.in	Sun Dec 12 21:08:59 1999
-@@ -24,8 +24,8 @@
- LIBS=@LIBS@
- DEFS=@DEFS@
- INCS=-I$(srcdir) -I$(srcdir)/../include $(INCLUDE)
--CXXFLAGS=@CXXFLAGS@ $(INCS) $(DEBUG) $(DEFS)
--CFLAGS=@CFLAGS@ $(DEBUG) $(DEFS)
-+CXXFLAGS=-O $(INCS) $(DEBUG) $(DEFS)
-+CFLAGS=-O $(DEBUG) $(DEFS)
- LDFLAGS=@LDFLAGS@
- MSGGENFLAGS=
- CXXDEPGENFLAGS=-MM

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message