From owner-freebsd-net@FreeBSD.ORG  Sat Dec 18 11:58:22 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8F8B51065674;
	Sat, 18 Dec 2010 11:58:22 +0000 (UTC)
	(envelope-from to.my.trociny@gmail.com)
Received: from mail-bw0-f48.google.com (mail-bw0-f48.google.com
	[209.85.214.48])
	by mx1.freebsd.org (Postfix) with ESMTP id E22028FC08;
	Sat, 18 Dec 2010 11:58:21 +0000 (UTC)
Received: by bwz8 with SMTP id 8so1411090bwz.7
	for <multiple recipients>; Sat, 18 Dec 2010 03:58:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:from:to:cc:subject:references
	:x-comment-to:date:in-reply-to:message-id:user-agent:mime-version
	:content-type; bh=rbOj3rnClzAxhmQRgNRJK06eQXmZ7vgpdqVmKjY3bko=;
	b=wIJHgBMEFCoN6lu9w1slETH5yBmHOTMga+f2zr3KI/qFG3BkeHNtK8Cz/avvrHfCCi
	rZc3RGJeU7mENZ9Qf2duJ5+yWyMUwgiO/RioL5ulCfyt/JqF+0dguItV6NuTzpEXTt46
	TG999R9Zp4JaTKOWbzeTH49VAC8Yrh98qG2BE=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:to:cc:subject:references:x-comment-to:date:in-reply-to
	:message-id:user-agent:mime-version:content-type;
	b=jxuMPmZNSuOsUrkCE9l6NWdNuFQUm3uMav31tWHa5m4JwqKbdKrDewVxjD9qQx66ST
	ji1f3PHXHaELmKpxNlRHIfydzHg2FOnhsVYy/tr/OJKRxAdf3xXI+d/XtddcGbNwZ/Uw
	j2mdzYVjHvby4QmkJ1DNpqaXzlo9ZNoDkWIPo=
Received: by 10.204.78.67 with SMTP id j3mr1255447bkk.144.1292673500908;
	Sat, 18 Dec 2010 03:58:20 -0800 (PST)
Received: from localhost ([95.69.174.185])
	by mx.google.com with ESMTPS id j11sm2517910bka.12.2010.12.18.03.58.19
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Sat, 18 Dec 2010 03:58:19 -0800 (PST)
From: Mikolaj Golub <to.my.trociny@gmail.com>
To: Kostik Belousov <kostikbel@gmail.com>
References: <86wrn7gxvd.fsf@kopusha.home.net>
	<20101218110358.GY33073@deviant.kiev.zoral.com.ua>
X-Comment-To: Kostik Belousov
Date: Sat, 18 Dec 2010 13:58:18 +0200
In-Reply-To: <20101218110358.GY33073@deviant.kiev.zoral.com.ua> (Kostik
	Belousov's message of "Sat, 18 Dec 2010 13:03:58 +0200")
Message-ID: <86sjxvgun9.fsf@kopusha.home.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Cc: freebsd-net@freebsd.org, Shteryana Shopova <syrinx@freebsd.org>
Subject: Re: bsnmp/snmpmod.h: #include <sys/queue.h> is missed
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Dec 2010 11:58:22 -0000

--=-=-=


On Sat, 18 Dec 2010 13:03:58 +0200 Kostik Belousov wrote:

 KB> On Sat, Dec 18, 2010 at 12:48:38PM +0200, Mikolaj Golub wrote:
 >> Hi,
 >> 
 >> bsnmp/snmpmod.h uses SLIST but does not includes <sys/queue.h>. This breaks
 >> net-mgmt/bsnmp-ucd port (ports/153153). 
 >> 
 >> Could somebody look at the attached patch?

 KB> <sys/types.h>, as well as <sys/param.h> should be included before
 KB> other headers.

Thanks. Overlooked this :-). 

-- 
Mikolaj Golub


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline; filename=snmpmod.h.patch

Index: contrib/bsnmp/snmpd/snmpmod.h
===================================================================
--- contrib/bsnmp/snmpd/snmpmod.h	(revision 216439)
+++ contrib/bsnmp/snmpd/snmpmod.h	(working copy)
@@ -34,6 +34,7 @@
 #define snmpmod_h_
 
 #include <sys/types.h>
+#include <sys/queue.h>
 #include <sys/socket.h>
 #include <net/if.h>
 #include <netinet/in.h>

--=-=-=--