From owner-svn-ports-all@freebsd.org Wed Oct 30 07:15:28 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 04E2817BFD8; Wed, 30 Oct 2019 07:15:28 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47308v6L92z4XXw; Wed, 30 Oct 2019 07:15:27 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: by mail-pl1-f172.google.com with SMTP id g9so569655plp.3; Wed, 30 Oct 2019 00:15:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mrhLdQPEjvHmPCUd21KQS/vxphP2a1SJ+LxXAgpgLTU=; b=ohAXO4tNrMt9z//qkev77vNufARtD2fynNNU4GawqbpfK4ASZZ+bfJ+T75QVWyjl5m LyygbohBKxjl37IXq+ffxfRcVJonHV0H2L8uXGEeUSYaqQwDZC+uTb2eGg+1X4zwsn+Y fS2oFmZdEgWEMwyNNj28mSMCw2IAEGAl8T2RV5Kaqm8JpMSGfbUM4WqCqcJ9PMw79FLx 4VbLkEHbyrgkagw5Ea2qpWCCNCZVbY7l8P/FcetNV7j1FgYXCiDtLUF7KfM1hlg366rC UvFDMSEsNMx2tZ/deACSiZk7sT9zCgMCsz9GgTvCW3lXeAhDC422bwoJYDtqHHyT7xxy xOIw== X-Gm-Message-State: APjAAAUAMfflBgP1IM/fg3IutUSGR1JqqJuk5eDhKK7Zob4E/M+aRXlM HXEpvy/gj/NMb3qFPdG6ndMBEcbCM3dloQ== X-Google-Smtp-Source: APXvYqwit1nMEnxPAHCCKD7m4oT2bgI4pG3Fxr7KFTjJU5G+3auCRTpsxBMGw50IDiG5vqvTNIbO8g== X-Received: by 2002:a17:902:a98c:: with SMTP id bh12mr2952280plb.289.1572419725774; Wed, 30 Oct 2019 00:15:25 -0700 (PDT) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com. [209.85.210.175]) by smtp.gmail.com with ESMTPSA id z13sm1698107pgz.42.2019.10.30.00.15.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Oct 2019 00:15:25 -0700 (PDT) Received: by mail-pf1-f175.google.com with SMTP id q26so908692pfn.11; Wed, 30 Oct 2019 00:15:25 -0700 (PDT) X-Received: by 2002:a65:4843:: with SMTP id i3mr13318290pgs.184.1572419724783; Wed, 30 Oct 2019 00:15:24 -0700 (PDT) MIME-Version: 1.0 References: <201910271742.x9RHgvQP017264@repo.freebsd.org> <09d56af7-96f5-dcfd-d70c-d20d54e97ea2@rawbw.com> <20191027222033.GA81623@urd.tobik.me> <778754a2-2aa5-831a-7441-a9a59c25b512@rawbw.com> <1d688197-0ca7-025d-bdcd-4d23631182b2@gmail.com> <20191028222852.mrgkywe5vjvsvpdk@atuin.in.mat.cc> <20191030062749.tersvou4qmhg2xv2@atuin.in.mat.cc> In-Reply-To: <20191030062749.tersvou4qmhg2xv2@atuin.in.mat.cc> From: Gleb Popov Date: Wed, 30 Oct 2019 11:15:00 +0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r515803 - head/devel/bazel To: Mathieu Arnold Cc: Jason Bacon , Yuri , Tobias Kortkamp , Raphael Kubo da Costa , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org X-Rspamd-Queue-Id: 47308v6L92z4XXw X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Oct 2019 07:15:28 -0000 On Wed, Oct 30, 2019 at 10:27 AM Mathieu Arnold wrote: > On Tue, Oct 29, 2019 at 09:33:10AM +0400, Gleb Popov wrote: > > My approach at least provide a stable binary package, and actually a > > way to build from source too - it just don't follow usual `make > > install` procedure. > > The problem with that is that comes from some false assumption. It is > not *your* port. As such it is not ok to have some obscure steps that > nobody else knows about. Ports belong to everyone, and anyone should be > able to update a port. If you have to do some arcane thing that is not > in the normal procedure to build a port, like pregenerating some binary > package (which is what the port is supposed to do in the first place), > then you are doing it wrong. > Actually, there are many examples in our ports tree that use "arcane things". Uses/cabal.mk has auxiliary targets to generate large portions of Haskell ports Makefiles. You can, in theory, write them manually, but this is exceptionally tedious. I believe, something like that is also implemented for Go and Rust ports. The same thing for wine-i386. >From my experience, it is not that often when you can update the port just by bumping {PORT,DIST}VERSION. In most cases you still need to do "obscure steps", depending on your understanding of obscurity. Some of which are documented and some are not. Speaking for myself, I did documented cabal.mk (although not in Porter Handbook) and also would have document TensorFlow's Makefile, would the port be finished. Again, I agree that making TensorFlow build the usual way is better than any other approach, but we can see that maintainer can't keep up with it. And no wonder - it is extermely large piece of software with unfriendly build system. So, I still lean toward prepackaged approach + documenting the procedure. > -- > Mathieu Arnold >