From owner-freebsd-ports@FreeBSD.ORG  Tue Feb  7 14:16:20 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: freebsd-ports@freebsd.org
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C530016A440;
	Tue,  7 Feb 2006 14:16:20 +0000 (GMT)
	(envelope-from laszlof@vonostingroup.com)
Received: from ritamari.vonostingroup.com (ritamari.vonostingroup.com
	[216.144.193.230])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 34E8543D4C;
	Tue,  7 Feb 2006 14:16:20 +0000 (GMT)
	(envelope-from laszlof@vonostingroup.com)
Received: from adsl-68-72-248-38.dsl.sfldmi.ameritech.net ([68.72.248.38]
	helo=[192.168.1.33])
	by ritamari.vonostingroup.com with esmtpa (Exim 4.60 (FreeBSD))
	(envelope-from <laszlof@vonostingroup.com>)
	id 1F6Te6-000CUG-Sg; Tue, 07 Feb 2006 09:16:43 -0500
Message-ID: <43E8ABB1.5020606@vonostingroup.com>
Date: Tue, 07 Feb 2006 09:16:17 -0500
From: Frank Laszlo <laszlof@vonostingroup.com>
User-Agent: Thunderbird 1.5 (Windows/20051201)
MIME-Version: 1.0
To: Sergey Matveychuk <sem@FreeBSD.org>
References: <20060207003529.GA32317@hades.panopticon>	
	<43E8A5DD.5000509@vonostingroup.com>
	<b8a404110602070606s6a0df93ah@mail.gmail.com>
In-Reply-To: <b8a404110602070606s6a0df93ah@mail.gmail.com>
X-Enigmail-Version: 0.93.2.0
OpenPGP: url=http://www.franksworld.org/~laszlof/keys/0x0B3FCA4B.asc
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse,
	please include it with any abuse report
X-AntiAbuse: Primary Hostname - ritamari.vonostingroup.com
X-AntiAbuse: Original Domain - freebsd.org
X-AntiAbuse: Originator/Caller UID/GID - [0 0] / [26 6]
X-AntiAbuse: Sender Address Domain - vonostingroup.com
X-Source: 
X-Source-Args: 
X-Source-Dir: 
Cc: amdmi3@mail.ru, freebsd-ports@freebsd.org
Subject: Re: USE_DOS2UNIX may be more powerful?
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Feb 2006 14:16:20 -0000

Sergey Matveychuk wrote:
> 2006/2/7, Frank Laszlo <laszlof@vonostingroup.com
> <mailto:laszlof@vonostingroup.com>>:
>
>     Dmitry Marakasov wrote:
>     >
>     > If the idea gets accepted, I'll make patches.
>     >
>     >
>
>     Sounds like a pretty reasonable idea. But I think USE_* is generally
>     just on/off switches, so maybe it needs to be a different name?
>
>
> We already have USE_*=list. E.g. USE_GNOME, USE_RCORDER etc.
>
> But I think using of something like DOS2UNIX_FILES name will be better
> in the case.
>
> 2Dmitry: patches are always welcome.
>
Ha, I just noticed it already does this. Look at the code:

.if defined(USE_DOS2UNIX)
.if ${USE_DOS2UNIX:U}=="YES"
    @${ECHO_MSG} "===>   Converting DOS text files to UNIX text files"
    @${FIND} -E ${WRKSRC} -type f -print0 | \
            ${XARGS} -0 ${REINPLACE_CMD} -i"" -e 's/[[:cntrl:]]*$$//'
.else
.for f in ${USE_DOS2UNIX}
    @${ECHO_MSG} "===>   Converting DOS text file to UNIX text file: ${f}"
    @${REINPLACE_CMD} -i"" -e 's/[[:cntrl:]]*$$//' ${WRKSRC}/${f}
.endfor
.endif

So you can define it either way..

USE_DOS2UNIX=YES    <-- this will parse ALL files within WRKSRC
USE_DOS2UNIX=foo/*.c bar/biz/*.h    <-- this will parse only certain files.

Hope this helps.

-Frank