From owner-freebsd-arch@FreeBSD.ORG Tue Sep 21 22:50:40 2004 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB12916A4CE; Tue, 21 Sep 2004 22:50:40 +0000 (GMT) Received: from mail.vicor-nb.com (bigwoop.vicor-nb.com [208.206.78.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8068643D53; Tue, 21 Sep 2004 22:50:40 +0000 (GMT) (envelope-from julian@elischer.org) Received: from elischer.org (julian.vicor-nb.com [208.206.78.97]) by mail.vicor-nb.com (Postfix) with ESMTP id 6356D7A3E1; Tue, 21 Sep 2004 15:50:40 -0700 (PDT) Message-ID: <4150B03F.4070207@elischer.org> Date: Tue, 21 Sep 2004 15:50:39 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3.1) Gecko/20030516 X-Accept-Language: en, hu MIME-Version: 1.0 To: Sam References: <415083CC.7C041DFD@freebsd.org> <41508827.8010007@elischer.org> <41508FEB.6030203@elischer.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: Andre Oppermann cc: freebsd-arch@freebsd.org Subject: Re: AoE for 4.x X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2004 22:50:41 -0000 Sam wrote: >> >> >> I guess we are used to it. >> >> I can't recommend enough the utility of having a cvs mirror and using >> cvs to keep your >> work trees sync'd against FreeBSD. It is also a goodd way of making >> sure that you don't >> forget parts of the diff (e.g. Makefiles etc.) as CVS will pick up >> all the changed files. >> > > And I can't thank you enough. I forgot about a few other (rather) > important file changes this picked up. > > A patchfile for aoe against today's 4.10 source tree > is at: > http://www.coraid.com/support/freebsd/aoe.patch > > A few notes: > > The file sys/dev/aoe/aoe4bsd.dd is basic documentation for > the driver. > > All references to chr major 200 will have to be changed to whatever > gets assigned, obviously. > > The netisr selected in sys/net/netisr.h was picked at random. Is it > OK? > > The label typeunknown in sys/net/if_ethersubr.c is added to give > netgraph a chance to get the packets if AoE is not loaded. Appropriate? > > I dinna know how to fill out the copyright/license comment in the > headers, > but i gave it a shot. Thoughts here would be appreciated. > > TIA to all the curious eyes that skim the driver for glaring flaws. haven't read it yet, just skimmed.. Very CLEAN looking code.. style(9) complient to a large extent.. (you do know about 'man 9 style' right?) now that it is written, this is the time to go through it and write down everything that comes to mind in comments.. Everything that a person trying to decode the driver might want to know. Including comments about the standards, tricky bits of code, reasons you decided to do things in certain ways. etc. > > > Cheers, > > Sam