Date: Tue, 21 Sep 2004 15:50:39 -0700 From: Julian Elischer <julian@elischer.org> To: Sam <sah@softcardsystems.com> Cc: freebsd-arch@freebsd.org Subject: Re: AoE for 4.x Message-ID: <4150B03F.4070207@elischer.org> In-Reply-To: <Pine.LNX.4.60.0409211808020.2887@athena> References: <Pine.LNX.4.60.0409211531450.32120@athena> <415083CC.7C041DFD@freebsd.org> <Pine.LNX.4.60.0409211541190.32120@athena> <41508827.8010007@elischer.org> <Pine.LNX.4.60.0409211603320.32120@athena> <41508FEB.6030203@elischer.org> <Pine.LNX.4.60.0409211808020.2887@athena>
next in thread | previous in thread | raw e-mail | index | archive | help
Sam wrote: >> >> >> I guess we are used to it. >> >> I can't recommend enough the utility of having a cvs mirror and using >> cvs to keep your >> work trees sync'd against FreeBSD. It is also a goodd way of making >> sure that you don't >> forget parts of the diff (e.g. Makefiles etc.) as CVS will pick up >> all the changed files. >> > > And I can't thank you enough. I forgot about a few other (rather) > important file changes this picked up. > > A patchfile for aoe against today's 4.10 source tree > is at: > http://www.coraid.com/support/freebsd/aoe.patch > > A few notes: > > The file sys/dev/aoe/aoe4bsd.dd is basic documentation for > the driver. > > All references to chr major 200 will have to be changed to whatever > gets assigned, obviously. > > The netisr selected in sys/net/netisr.h was picked at random. Is it > OK? > > The label typeunknown in sys/net/if_ethersubr.c is added to give > netgraph a chance to get the packets if AoE is not loaded. Appropriate? > > I dinna know how to fill out the copyright/license comment in the > headers, > but i gave it a shot. Thoughts here would be appreciated. > > TIA to all the curious eyes that skim the driver for glaring flaws. haven't read it yet, just skimmed.. Very CLEAN looking code.. style(9) complient to a large extent.. (you do know about 'man 9 style' right?) now that it is written, this is the time to go through it and write down everything that comes to mind in comments.. Everything that a person trying to decode the driver might want to know. Including comments about the standards, tricky bits of code, reasons you decided to do things in certain ways. etc. > > > Cheers, > > Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4150B03F.4070207>