From owner-cvs-all Thu Jan 16 14:43:14 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE63337B401; Thu, 16 Jan 2003 14:43:12 -0800 (PST) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2140B43E4A; Thu, 16 Jan 2003 14:43:12 -0800 (PST) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.12.6/8.12.5) with SMTP id h0GMh1P4012979; Thu, 16 Jan 2003 17:43:01 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Thu, 16 Jan 2003 17:43:00 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Sam Leffler Cc: "Justin T. Gibbs" , Nate Lawson , Hidetoshi Shimokawa , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/firewire firewire.c fwdev.c fwohci.c fwohcivar.h In-Reply-To: <20e801c2bdad$770d56f0$5a557f42@errno.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 16 Jan 2003, Sam Leffler wrote: > > >> - contigfree((void *)(uintptr_t)sc->fc.sid_buf, > > >> - OHCI_SIDSIZE, M_DEVBUF); > > >> + free((void *)(uintptr_t)sc->fc.sid_buf, M_DEVBUF); > > > > malloced buffers are not guaranteed to be accessable by a device. > > Use bus dma instead. > > New drivers should use bus_dma. I recently hit an issue like this with > jumbo mbufs not being handled by the bge driver because it doesn't use > bus dma. Yeah, agreed. mux, tmm, and others have been doing a nice job of pushing over drivers to busdma, but we basically need to disallow any non-busdma drivers from being added from now on. A reasonable strategy is that existing drivers must be converted by current maintainers, if any, by 5.1. If there's no maintainer, we pick them up more gradually. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message