From owner-svn-src-head@freebsd.org Sun Nov 12 02:45:08 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0A49FE66194; Sun, 12 Nov 2017 02:45:08 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DA70878D3F; Sun, 12 Nov 2017 02:45:07 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: by mail-pf0-f194.google.com with SMTP id b6so9177922pff.10; Sat, 11 Nov 2017 18:45:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=mM3wKbnvdAKrna9Y0HL3VE3ahRGDTZVNmJWOZhOOAoQ=; b=oemvwYNzfiUfepDUIfwnT4ZPnKma6vV+uZZ/z0iXwbg6LsurOC9vC28jqpkmfvf0PU AXD3cozkkx8x+u+Ub5hOFZg9VmKmB0CXf0Tnqa2JDZhci2r5/b3Ema2Te+j3BvbPK5cG G9gF26BCdr3Q4W+RqHyBZjjD7b824/tWXPXEBy4YXI8ahmLb87B/RMOV/iJgqSf/p1j5 yH5O/LWLbQNpfm3afQRFD/v6uP1u8/SbN5Xzglp8fxVNZTt/JjLfVFWEGzuq9oOBd1RZ 5tqWZKyopS8zQslsRnc8urQoUB2TzkDE950Gir1v/PJ/ThbT7AezdBUSjcyIa6ATzkq1 RWMg== X-Gm-Message-State: AJaThX5aT6nuyXpa+WzwqyxCXIwEGXiD9ccPfMg4hbgrXtgY48aEqL55 vrxRYh3o0Uxn/mfxIyeyY+bTw7G4 X-Google-Smtp-Source: AGs4zMbLUa2+hF85rjpuNRJN0ICnQ8rwlrMW+L5mCUJ/ugtC7Tjl8518dXH8GcQz/qRLNn6mAs6Lkg== X-Received: by 10.159.244.136 with SMTP id y8mr4708475plr.251.1510444412273; Sat, 11 Nov 2017 15:53:32 -0800 (PST) Received: from [192.168.2.122] (174-24-242-218.tukw.qwest.net. [174.24.242.218]) by smtp.gmail.com with ESMTPSA id y20sm594508pgc.52.2017.11.11.15.53.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Nov 2017 15:53:31 -0800 (PST) Subject: Re: svn commit: r325728 - head/lib/libkvm To: Will Andrews , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201711112330.vABNUwXC077395@repo.freebsd.org> From: Matt Joras Message-ID: <7b61c948-7b54-7590-e633-bd0e29291c27@FreeBSD.org> Date: Sat, 11 Nov 2017 15:53:30 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201711112330.vABNUwXC077395@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2017 02:45:08 -0000 On 11/11/2017 15:30, Will Andrews wrote: > Author: will > Date: Sat Nov 11 23:30:58 2017 > New Revision: 325728 > URL: https://svnweb.freebsd.org/changeset/base/325728 > > Log: > libkvm: add kvm_walk_pages API. > > This API allows callers to enumerate all known pages, including any > direct map & kernel map virtual addresses, physical addresses, size, > offset into the core, & protection configured. > > For architectures that support direct map addresses, also generate pages > for any direct map only addresses that are not associated with kernel > map addresses. > > Fix page size portability issue left behind from previous kvm page table > lookup interface. > > Reviewed by: jhb > Sponsored by: Backtrace I/O > Differential Revision: https://reviews.freebsd.org/D12279 This broke powerpc, riscv64, sparc64: *23:36:15* /usr/src/lib/libkvm/kvm_private.c: In function '_kvm_bitmap_init': *23:36:15* /usr/src/lib/libkvm/kvm_private.c:702: warning: declaration of 'index' shadows a global declaration *23:36:15* /usr/obj/usr/src/powerpc.powerpc/tmp/usr/include/strings.h:60: warning: shadowed declaration is here *23:36:15* /usr/src/lib/libkvm/kvm_private.c: In function '_kvm_bitmap_next': *23:36:15* /usr/src/lib/libkvm/kvm_private.c:723: warning: declaration of 'index' shadows a global declaration *23:36:15* /usr/obj/usr/src/powerpc.powerpc/tmp/usr/include/strings.h:60: warning: shadowed declaration is here *23:36:15* *** [kvm_private.o] Error code 1