From owner-freebsd-current@FreeBSD.ORG  Tue Jul  2 23:23:12 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id D721DE2A
 for <freebsd-current@freebsd.org>; Tue,  2 Jul 2013 23:23:12 +0000 (UTC)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
 [128.95.76.21]) by mx1.freebsd.org (Postfix) with ESMTP id BBEE91BB5
 for <freebsd-current@freebsd.org>; Tue,  2 Jul 2013 23:23:12 +0000 (UTC)
Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu
 [127.0.0.1])
 by troutmask.apl.washington.edu (8.14.6/8.14.6) with ESMTP id r62NNATR069341; 
 Tue, 2 Jul 2013 16:23:10 -0700 (PDT)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
 by troutmask.apl.washington.edu (8.14.6/8.14.6/Submit) id r62NNAeF069340;
 Tue, 2 Jul 2013 16:23:10 -0700 (PDT) (envelope-from sgk)
Date: Tue, 2 Jul 2013 16:23:10 -0700
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Ed Schouten <ed@80386.nl>
Subject: Re: [PATCH] nvmecontrol breaks world
Message-ID: <20130702232310.GB69299@troutmask.apl.washington.edu>
References: <20130702201728.GA68544@troutmask.apl.washington.edu>
 <CAJOYFBCWzzT7kSABROsyJsbt+N=KhQ3vmW4TJjw3Toxsxu836A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJOYFBCWzzT7kSABROsyJsbt+N=KhQ3vmW4TJjw3Toxsxu836A@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: FreeBSD Current <freebsd-current@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jul 2013 23:23:12 -0000

On Tue, Jul 02, 2013 at 10:30:53PM +0200, Ed Schouten wrote:
> 2013/7/2 Steve Kargl <sgk@troutmask.apl.washington.edu>:
> > Could someone (this could even be me, but need approval) please
> > fix nvmecontrol?
> 
> off_t doesn't need to be intmax_t, right? Maybe add an explicit cast?
> Also, the call of malloc(sb.st_size) is not really safe...
> 

jimharris committed the patch.  I suspect that this is intel
code, which needs to be portable to other OS's.  Hopefully,
he fixes the build soon. 

-- 
Steve