From owner-freebsd-stable@FreeBSD.ORG Sun Jan 13 16:56:38 2013 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 19ECAE6F; Sun, 13 Jan 2013 16:56:38 +0000 (UTC) (envelope-from nox@jelal.kn-bremen.de) Received: from smtp.kn-bremen.de (gelbbaer.kn-bremen.de [78.46.108.116]) by mx1.freebsd.org (Postfix) with ESMTP id CAED2EEF; Sun, 13 Jan 2013 16:56:37 +0000 (UTC) Received: by smtp.kn-bremen.de (Postfix, from userid 10) id C27E91E00079; Sun, 13 Jan 2013 17:48:54 +0100 (CET) Received: from triton8.kn-bremen.de (noident@localhost [127.0.0.1]) by triton8.kn-bremen.de (8.14.5/8.14.4) with ESMTP id r0DGmdIo073986; Sun, 13 Jan 2013 17:48:39 +0100 (CET) (envelope-from nox@triton8.kn-bremen.de) Received: (from nox@localhost) by triton8.kn-bremen.de (8.14.5/8.14.3/Submit) id r0DGmcFC073985; Sun, 13 Jan 2013 17:48:38 +0100 (CET) (envelope-from nox) From: Juergen Lock Date: Sun, 13 Jan 2013 17:48:38 +0100 To: Markiyan Kushnir Subject: Re: VIDIOC_ENUM_FRAMESIZES in linux_ioctl.c Message-ID: <20130113164838.GA73810@triton8.kn-bremen.de> References: <50F2DCA1.8080208@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50F2DCA1.8080208@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: nox@freebsd.org, stable@freebsd.org, netchild@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jan 2013 16:56:38 -0000 On Sun, Jan 13, 2013 at 06:11:13PM +0200, Markiyan Kushnir wrote: > Hi, > > Any reason why LINUX_VIDIOC_ENUM_FRAMESIZES, > LINUX_VIDIOC_ENUM_FRAMEINTERVALS, LINUX_VIDIOC_ENCODER_CMD, and > LINUX_VIDIOC_TRY_ENCODER_CMD in compat/linux/linux_ioctl.c have been put > under #ifdef VIDIOC_ENUM_FRAMESIZES (looks like it's been there since > rev. 221426, when the v4l2 support was introduced) ? > > I've just hit an issue with the current Skypes in the ports tree (both > 2.1.0.81 and 2.2.0.35) trying to call at least the > LINUX_VIDIOC_ENUM_FRAMESIZES ioctl, so I re-built linux.ko with > -DVIDIOC_ENUM_FRAMESIZES and found no visible issues on my desktop so > far beyond that my skype started to send video. > > If there is some reason, it would be good to let people know why these > ioctls are turned off by default. > IIRC netchild's concern was that these were not in Linux 2.6.16 that our Linuxolator defaults to emulating, so I put them under #ifdef. Did you find that skype video doesn't work without them? Back when I tested it it didn't seem to make a difference... (Tho I never could get skype 2.2.0.35 to work with video, I think because it tries to use inotify() which we don't emulate.) HTH, Juergen