From owner-svn-src-head@FreeBSD.ORG Sat Jun 20 13:32:04 2015 Return-Path: Delivered-To: svn-src-head@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1E6FCCC0; Sat, 20 Jun 2015 13:32:04 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EBDC1D2D; Sat, 20 Jun 2015 13:32:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (d-69-161-105-82.cpe.metrocast.net [69.161.105.82]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id AC236B91F; Sat, 20 Jun 2015 09:32:02 -0400 (EDT) Message-ID: <55856B52.9040802@FreeBSD.org> Date: Sat, 20 Jun 2015 09:32:02 -0400 From: John Baldwin User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Konstantin Belousov , Sean Bruno CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r284535 - head/sys/kern References: <201506180204.t5I24LJm079537@svn.freebsd.org> <20150618030715.GD2080@kib.kiev.ua> In-Reply-To: <20150618030715.GD2080@kib.kiev.ua> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Sat, 20 Jun 2015 09:32:03 -0400 (EDT) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jun 2015 13:32:04 -0000 On 6/17/15 11:07 PM, Konstantin Belousov wrote: > On Thu, Jun 18, 2015 at 02:04:21AM +0000, Sean Bruno wrote: >> Author: sbruno >> Date: Thu Jun 18 02:04:20 2015 >> New Revision: 284535 >> URL: https://svnweb.freebsd.org/changeset/base/284535 >> >> Log: >> This change replaces the mutex with a sx lock for the interpreter list to >> avoid the problem of holding a non-sleep lock during a page fault as >> reported by witness. It also uses atomics where possible to avoid having >> to acquire the exclusive lock. In addition, it consistently uses >> memset()/memcpy() instead of bzero()/bcopy(). >> >> Differential Revision: https://reviews.freebsd.org/D1971 >> Submitted by: sson >> Reviewed by: jhb > What are the page faults during image activator run ? > Or, if the page faults are not during image activation, then where ? It took me a while to figure out while reviewing, but the exec_map memory is pageable, so the bcopy to move things around inside of it can fault. -- John Baldwin