From owner-cvs-src@FreeBSD.ORG  Tue Dec 19 17:45:10 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3599616A47C;
	Tue, 19 Dec 2006 17:45:10 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D1BC843CA8;
	Tue, 19 Dec 2006 17:45:05 +0000 (GMT) (envelope-from sam@errno.com)
Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id kBJHj3xg088472
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 19 Dec 2006 09:45:04 -0800 (PST) (envelope-from sam@errno.com)
Message-ID: <4588251F.3040206@errno.com>
Date: Tue, 19 Dec 2006 09:45:03 -0800
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 1.5.0.8 (X11/20061115)
MIME-Version: 1.0
To: Martin Blapp <mb@imp.ch>
References: <200612191646.kBJGkEln071323@repoman.freebsd.org>
	<45881D46.8090201@errno.com> <20061219181505.L53548@godot.imp.ch>
In-Reply-To: <20061219181505.L53548@godot.imp.ch>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern tty.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Dec 2006 17:45:10 -0000

Martin Blapp wrote:
> 
> Hi Sam,
> 
> I'll have got again a setup box in the next week and work hard
> with bde, gib and tegge to solve them. For RELENG_6_2 it's
> too late. I hope to get that small workaround again committed,
> but for more serios work we would have to delay 6.2 for half a
> year ;-)
> 
> The full tty locking stuff is also pendent, maybe I'll grab that
> and make it work. Unfortunatly this will open again a new 'can of worms':
> new races will appear.
> 
> Martin
> 
>>>   Modified files:
>>>     sys/kern             tty.c
>>>   Log:
>>>   Add the tp->t_refcnt validity check back. There are still some race
>>>   conditions where tp->t_refcnt can go to zero.
>>
>> Can you please identify those races?

That is not what I was asking for.  You said "there are races" but
didn't identify them.  It would be helpful to know what these races are
so someone other than you doesn't need to guess why you made this change.

	Sam