From owner-svn-src-head@freebsd.org Sat Nov 14 00:00:19 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 733FBA2E609 for ; Sat, 14 Nov 2015 00:00:19 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 026BA1D82 for ; Sat, 14 Nov 2015 00:00:19 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: by wmec201 with SMTP id c201so104073045wme.0 for ; Fri, 13 Nov 2015 16:00:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay_co_uk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=7h5Jje11PEIiQiuCfTm3EaB43561fGuXycPfHF970Hc=; b=rxXVUNxt/wWf+ayz0UWH9AWPRapmf58CSjSL+/Gk6zmUGqbMOKtILaaKipni9zNlh6 xYoBcsr1g0MXm3JcxYmZ97W5hBZjTr+92ZdON3LBayPwKJO2Jc34KFJbDwPj2k93J7zF w2Gto+gl0dSDImpf0D6CCZbrbxZd8HNeyHMLb+z+WfU7K0tQtbT9XgwYzVzW5SC76kpR U3ipkjnp/N00FEalv7dsoKJLkfmKAplWmfkqI4sYptr6+j/vCv0uEi2/1MKWZPRPVwjO Eu/hloUxeytupfYm22/a3zpJzAjfkS/ptxBjUbOlF63gMTNz4vndUxB7NpmwF43Y0V/A +DaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=7h5Jje11PEIiQiuCfTm3EaB43561fGuXycPfHF970Hc=; b=lLf4I/2H8clXgtkKpcVg9mZijChbp5BKlZxPngp6lra0+WzODzERBD5nIcXViVmDll Wy0Nc0hbM38esfANYo5ByX/oOebnRZZeuCEc73bKxa/ifhCDztETJXSIGecGen7Q8U6N g0yVNjchzFzG9XQ8WA4O7pbVAYHsqiQfM2Pjb9OTSiWVoHFET9Ue1nFCQviqh1lkJxET 1uhLuoAwu1nYTfxhIbimx/9k7awlJBc01n/r4RM9GwN2rSyBrU2n9z1gPDkUx0z13T+l O39vR9GCXkrnWluiJMBJ4bEULTDplFNSxI+LvC128jNyUFg9R1kMfBT1A51X+A/1H3dB yhnA== X-Gm-Message-State: ALoCoQkJ2gt6jKj2S9/exW5lh5KDZXnzL7qN4gj+2zg8ruS54i2Q0qKqFWIR66hdYoJLXtQIAD6w X-Received: by 10.28.73.11 with SMTP id w11mr6201386wma.44.1447459217513; Fri, 13 Nov 2015 16:00:17 -0800 (PST) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id q1sm22126130wjy.31.2015.11.13.16.00.16 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 13 Nov 2015 16:00:16 -0800 (PST) Subject: Re: svn commit: r290603 - in head/sys: net netgraph netinet To: Gleb Smirnoff , "Alexander V. Chernikov" References: <201511091011.tA9ABFWb029549@repo.freebsd.org> <20151113225400.GE73031@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Steven Hartland Message-ID: <5646799E.3030806@multiplay.co.uk> Date: Sat, 14 Nov 2015 00:00:30 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151113225400.GE73031@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Nov 2015 00:00:19 -0000 On 13/11/2015 22:54, Gleb Smirnoff wrote: > Alexander, > > On Mon, Nov 09, 2015 at 10:11:15AM +0000, Alexander V. Chernikov wrote: > A> Author: melifaro > A> Date: Mon Nov 9 10:11:14 2015 > A> New Revision: 290603 > A> URL: https://svnweb.freebsd.org/changeset/base/290603 > A> > A> Log: > A> Use lladdr_event to propagate gratiotus arp. > A> > A> Differential Revision: https://reviews.freebsd.org/D4019 > > Looking into a diff a lame question emerges: why can't the call > to EVENTHANDLER_INVOKE() moved right into the end of the > if_setlladdr()? > This would indeed be a good change, not only does it eliminate duplicate code, simplifying things but it also ensures the event is fired if more callers are added. Regards Steve