Date: Sat, 7 Nov 2015 20:57:55 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Andrey Chernov <ache@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, jasone@FreeBSD.org Subject: Re: svn commit: r290499 - head/usr.bin/localedef Message-ID: <20151107195755.GC31396@ivaldir.etoilebsd.net> In-Reply-To: <20151107165636.GA31396@ivaldir.etoilebsd.net> References: <201511071622.tA7GMTDN099727@repo.freebsd.org> <563E2BA6.9020505@freebsd.org> <20151107165636.GA31396@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--f+W+jCU1fRNres8c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 07, 2015 at 05:56:36PM +0100, Baptiste Daroussin wrote: > On Sat, Nov 07, 2015 at 07:49:42PM +0300, Andrey Chernov wrote: > > On 07.11.2015 19:22, Baptiste Daroussin wrote: > > > Author: bapt > > > Date: Sat Nov 7 16:22:29 2015 > > > New Revision: 290499 > > > URL: https://svnweb.freebsd.org/changeset/base/290499 > > >=20 > > > Log: > > > Workaround an issue on i386 to unbreak the build until the real iss= ue is tracked > > > down > > > - large =3D calloc(sizeof (collate_large_t) * n, 1); > > > + large =3D malloc(sizeof (collate_large_t) * n); > > > + memset(large, 0, sizeof (collate_large_t) * n); > >=20 > > Should be calloc(n, sizeof (collate_large_t)) according to calloc usage > > and to prevent size_t overflow. Is it calloc() bug? >=20 > I have tried all combinaison with calloc before committing the workaround= , all > fails the same way on i386: > <jemalloc>: jemalloc_arena.c:353: Failed assertion: "p[i] =3D=3D 0" >=20 > So yes I'm thinking about a calloc bug (Jason CCed) >=20 > FYI sizeof(collate_large_t) is 44 there and n is 1145 >=20 > Best regards, > Bapt Issue found by dim@ using the Address Sanitizer Guilty was me through a bug I introduced during conversion from avl(3) to tree(3). Best regards, Bapt --f+W+jCU1fRNres8c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlY+V8MACgkQ8kTtMUmk6EwnpgCgiGB4A1tY9Q86PRUMYhqNuLxP b+AAnA4pc9Fx3N6Apn8Uin4TRUuIEHhe =bois -----END PGP SIGNATURE----- --f+W+jCU1fRNres8c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151107195755.GC31396>