From owner-freebsd-current@FreeBSD.ORG Tue Jun 26 19:55:50 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49157106566B for ; Tue, 26 Jun 2012 19:55:50 +0000 (UTC) (envelope-from pfg@freebsd.org) Received: from nm8-vm0.bullet.mail.sp2.yahoo.com (nm8-vm0.bullet.mail.sp2.yahoo.com [98.139.91.194]) by mx1.freebsd.org (Postfix) with SMTP id 1DC608FC17 for ; Tue, 26 Jun 2012 19:55:50 +0000 (UTC) Received: from [72.30.22.92] by nm8.bullet.mail.sp2.yahoo.com with NNFMP; 26 Jun 2012 19:52:47 -0000 Received: from [98.139.91.36] by tm14.bullet.mail.sp2.yahoo.com with NNFMP; 26 Jun 2012 19:52:47 -0000 Received: from [127.0.0.1] by omp1036.mail.sp2.yahoo.com with NNFMP; 26 Jun 2012 19:52:47 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 881604.42396.bm@omp1036.mail.sp2.yahoo.com Received: (qmail 95180 invoked by uid 60001); 26 Jun 2012 19:52:47 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1340740367; bh=ZrSPH3fu+brPAEuVboUHed90EV4zAFoqZOJ3v0wvs+U=; h=X-YMail-OSG:Received:X-RocketYMMF:X-Mailer:Message-ID:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=yIpKk3L12Do7FPDfEqb7vDsjVmUezAa3Pxlp7o+1aj/6INsjU6s7CyI960oa0uEOCYjQ2eps+DFRgrybM+MV1ol+gl+6VDviTQPILOpz0Xeenp9onYaC0D6rvfBk/0C6x05Kbj3jw4xAIVXR8GRBbXsHLhYGapisEXJGWjvKf78= X-YMail-OSG: ZzH7RgwVM1lpKMak5pP9Ndmb5sVg67HGg.kVC2p_6oZWwe0 wz1oAL3rLy.VmvwuRfD9WLmKIG1B1YKkfOixGbNxqWCj2uBJLLWsEROGcce7 YkUSn.gqX5RBHRM_1n5VmgKNn2Lfj5I7CTEo2N4ANHvUIzIHdba1FqgP1urU H8EI71SbOR8Rk.pvpE9PeyW2XtNgY__gv9xiXSCsP3Kr8fSsARy6qpjrv7cW _jPS1CtpAV2jXBC6w6SOPTz7v8ae0MojHlw3bmuTvcGdPPUGTwPCKYxgRVrr hecB2wy8hKb7MO1tgdN_j3AmBi_0GGPyOojVjvQVpL1yJLcKTfoUCGx0yETq HlQr_ZTtsqSampvLSToxB5R4INrzjmt.eSgJHUzcRSZTEpOAqWbc4wvPqGyA n5WpwvxDPr4EHGIrSg90rjPrbV2p_HcS7kUm7jXrSCIqUqL5bINZPcteUmSL 9Sldd Received: from [200.118.157.7] by web113504.mail.gq1.yahoo.com via HTTP; Tue, 26 Jun 2012 12:52:47 PDT X-RocketYMMF: giffunip X-Mailer: YahooMailClassic/15.0.8 YahooMailWebService/0.8.118.349524 Message-ID: <1340740367.88309.YahooMailClassic@web113504.mail.gq1.yahoo.com> Date: Tue, 26 Jun 2012 12:52:47 -0700 (PDT) From: Pedro Giffuni To: Fabian Keil In-Reply-To: <20120626210606.632498e2@fabiankeil.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Mark Peek , freebsd-current@FreeBSD.org Subject: Re: [RFT] llquantize for FreeBSD's dtrace X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pfg@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2012 19:55:50 -0000 =0A=0A--- Mar 26/6/12, Fabian Keil ha scritt= o:=0A=0A> Pedro Giffuni wrote:=0A> =0A> > --- Mar 26/6/12= , Mark Peek =0A> ha scritto:=0A> =0A> > > Try this, change = the assert on line 1429 in file=0A> dt_cc.c=0A> > > from:=0A> > > =0A> > > = assert(!(arg & (UINT16_MAX <<=0A> args[i].shift)));=0A> > > =0A> > > to=0A>= > > =0A> > > assert(!(arg & ((uint64_t)UINT16_MAX <<=0A> > > args[i].shift= )));=0A> > > =0A> > =0A> > This certainly looks correct. Thanks Mark !=0A> = > =0A> > I updated the patch:=0A> > =0A> > http://people.freebsd.org/~pfg/p= atches/patch-dtrace-llquantize=0A> =0A> Thanks a lot. Seems to work for me:= =0A> =0A=0ANice!=0A=0AI don't use Dtrace though ... so I'll ask:=0A=0AAny o= bjections against committing it? :).=0A=0APedro.=0A=0A