From owner-svn-src-head@freebsd.org Sat Apr 14 22:14:19 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37F12F9E7FA; Sat, 14 Apr 2018 22:14:19 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E0C79827BE; Sat, 14 Apr 2018 22:14:18 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D53972E0A0; Sat, 14 Apr 2018 22:14:18 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w3EMEIN8028632; Sat, 14 Apr 2018 22:14:18 GMT (envelope-from imp@FreeBSD.org) Received: (from imp@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w3EMEIRu028631; Sat, 14 Apr 2018 22:14:18 GMT (envelope-from imp@FreeBSD.org) Message-Id: <201804142214.w3EMEIRu028631@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: imp set sender to imp@FreeBSD.org using -f From: Warner Losh Date: Sat, 14 Apr 2018 22:14:18 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r332509 - head/sys/i386/i386 X-SVN-Group: head X-SVN-Commit-Author: imp X-SVN-Commit-Paths: head/sys/i386/i386 X-SVN-Commit-Revision: 332509 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Apr 2018 22:14:19 -0000 Author: imp Date: Sat Apr 14 22:14:18 2018 New Revision: 332509 URL: https://svnweb.freebsd.org/changeset/base/332509 Log: Make first a 'bool' instead of a 'boolean_t'. 'bool' is preferred to 'boolean_t'. We only get the boolean_t definition by header pollution (though the same is true for bool). Since we use both, switch entirely to bool. Note: We still have TRUE/FALSE instead of true/false in heavy use in the rest of the file. These are with ints of various flavors, so that's appropriate, even though we should eventually migrate to bool and true/false (though the tables they are in are nicely packed with short and wouldn't be so nicely packed with bool, another reason to leave it alone for now). Modified: head/sys/i386/i386/db_disasm.c Modified: head/sys/i386/i386/db_disasm.c ============================================================================== --- head/sys/i386/i386/db_disasm.c Sat Apr 14 21:54:22 2018 (r332508) +++ head/sys/i386/i386/db_disasm.c Sat Apr 14 22:14:18 2018 (r332509) @@ -1166,7 +1166,7 @@ db_disasm(db_addr_t loc, bool altfmt) int i_size; int i_mode; int regmodrm = 0; - boolean_t first; + bool first; int displ; int prefix; int rep; @@ -1338,9 +1338,9 @@ db_disasm(db_addr_t loc, bool altfmt) } } db_printf("\t"); - for (first = TRUE; + for (first = true; i_mode != 0; - i_mode >>= 8, first = FALSE) + i_mode >>= 8, first = false) { if (!first) db_printf(",");