From nobody Sun Sep 14 20:13:22 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cPzr3294qz67PnJ; Sun, 14 Sep 2025 20:13:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cPzr24Kj4z3wfv; Sun, 14 Sep 2025 20:13:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757880802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eDbKVDsnjPpKEDSDkO+fRnlrlvhzKMfKS8vZkky5sac=; b=jzhHwDV84ClfOvA6TyWAvZPRzv3Q8O9zKbo9QJRMgerh7h59VWNNr6b2E6LGzjs1W3jNd8 xJI92ZcATnkxD5LSJzUMD0HmStYC1iV7ZbUHunCV3sRcsoBZu7MQLWrKEH5lRzgVjLWjYc 8CAJ3gmiyg4xXCQsb/n5qjyCfUK0UfrsX3Q0BYpa0aGO0QDvXxH64a5PRGqVCDC5y5F/42 tlH9acLz3Z2GIQG/kCXa5gQh+32hUkaumE65jGPvTafD1QOfiJKLqwtcEJM1SVxJ68NwI0 Svrx2rUh51U7WgZaoTIC9wG1aWK07WHRcX6pHQMUdJ4DA9WYkmPRFrS5FjIh/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757880802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eDbKVDsnjPpKEDSDkO+fRnlrlvhzKMfKS8vZkky5sac=; b=BA8cr6STA59lZgRKxU93n7sqhKGoKbr0lesVAgISdD+9X49yum/McYFmuGfFygUmXR6LPA whkrC9bBCV2Irb/ZIMJSuapxHWH5y6FYv3oGRY5BaP20DH1erVl4nMMoUXp4U3lZg3e4gd kdsnabPw30v5n6dh4eaMDFXKyWD7U4oIXmmEtmaZ6PoiVhFOwRcb6W7e1cxXJQX4hk67gn kHlbMGMUUQROWsVbyDpsdRaTkcIsjijW7/MQGDUjUYxJ13H191kesyRdnL3UPxP+BwD7nL qKXbl+239ouuzpve3C2OpwA/hcaJ9pZ+yJgAHEsr4S+kMDJrDBDG8E5RbHEJXQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757880802; a=rsa-sha256; cv=none; b=AcuOynP7xi8tYP7Ru5GyLfTkZGyH+W3qJh2CCZ1hzM5XZVrt5mpTn4ZemBsaontLEBH8Cb gvacKCKh7CvlCDtavF7w2KF+ZU1q8SN09/DnUjOFHpf1CXlq1ObPsInpZ/onB4bEiCTSBd OfG/OHuNO7dhQMSSkmKpo2oxH1WKLc0uB9NOPOx1Hu0A7nJuCXAThw4rZdN3dd3aWDxPuz BvqcfoumGPzC2IVhiw8KzR73GOq772CeKvoJD6ii0tOncWJJtXUWtzeSQgXiP/6QQawqla j7M/GFuCiyCsa4uPs204oQFEyGrXhz2mlS9dkktbvnwVNlOdalW9cDhR3WObfQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cPzr237KRz7mM; Sun, 14 Sep 2025 20:13:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58EKDMow066093; Sun, 14 Sep 2025 20:13:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58EKDMgB066090; Sun, 14 Sep 2025 20:13:22 GMT (envelope-from git) Date: Sun, 14 Sep 2025 20:13:22 GMT Message-Id: <202509142013.58EKDMgB066090@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 3f05bbdbd80f - main - vm_fault: add helper vm_fault_can_cow_rename() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3f05bbdbd80f2eefb647e595dc73e80d6186d6a5 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=3f05bbdbd80f2eefb647e595dc73e80d6186d6a5 commit 3f05bbdbd80f2eefb647e595dc73e80d6186d6a5 Author: Konstantin Belousov AuthorDate: 2025-07-24 10:47:52 +0000 Commit: Konstantin Belousov CommitDate: 2025-09-14 19:12:58 +0000 vm_fault: add helper vm_fault_can_cow_rename() Reviewed by: alc, markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D51474 --- sys/vm/vm_fault.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/sys/vm/vm_fault.c b/sys/vm/vm_fault.c index 226cf34b3ca4..27b5f72ec945 100644 --- a/sys/vm/vm_fault.c +++ b/sys/vm/vm_fault.c @@ -1006,6 +1006,16 @@ vm_fault_relookup(struct faultstate *fs) return (KERN_SUCCESS); } +static bool +vm_fault_can_cow_rename(struct faultstate *fs) +{ + return ( + /* Only one shadow object and no other refs. */ + fs->object->shadow_count == 1 && fs->object->ref_count == 1 && + /* No other ways to look the object up. */ + fs->object->handle == NULL && (fs->object->flags & OBJ_ANON) != 0); +} + static void vm_fault_cow(struct faultstate *fs) { @@ -1023,15 +1033,7 @@ vm_fault_cow(struct faultstate *fs) * object so that it will go out to swap when needed. */ is_first_object_locked = false; - if ( - /* - * Only one shadow object and no other refs. - */ - fs->object->shadow_count == 1 && fs->object->ref_count == 1 && - /* - * No other ways to look the object up - */ - fs->object->handle == NULL && (fs->object->flags & OBJ_ANON) != 0 && + if (vm_fault_can_cow_rename(fs) && /* * We don't chase down the shadow chain and we can acquire locks. */