From owner-cvs-all  Wed Oct 23 12: 0:32 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 016CF37B401; Wed, 23 Oct 2002 12:00:32 -0700 (PDT)
Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.157.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2AB8A43E4A; Wed, 23 Oct 2002 12:00:31 -0700 (PDT)
	(envelope-from mark@grimreaper.grondar.org)
Received: from storm.FreeBSD.org.uk (uucp@localhost [127.0.0.1])
	by storm.FreeBSD.org.uk (8.12.6/8.12.6) with ESMTP id g9NJ0TW1051757;
	Wed, 23 Oct 2002 20:00:30 +0100 (BST)
	(envelope-from mark@grimreaper.grondar.org)
Received: (from uucp@localhost)
	by storm.FreeBSD.org.uk (8.12.6/8.12.6/Submit) with UUCP id g9NJ0T2C051756;
	Wed, 23 Oct 2002 20:00:29 +0100 (BST)
Received: from grimreaper.grondar.org (localhost [127.0.0.1])
	by grimreaper.grondar.org (8.12.6/8.12.5) with ESMTP id g9NIuIks095533;
	Wed, 23 Oct 2002 19:56:18 +0100 (BST)
	(envelope-from mark@grimreaper.grondar.org)
Message-Id: <200210231856.g9NIuIks095533@grimreaper.grondar.org>
To: Bruce Evans <bde@zeta.org.au>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/include stdlib.h src/lib/libc/gen getbsize.3 getbsize.c 
References: <20021024035920.R23637-100000@gamplex.bde.org> 
In-Reply-To: <20021024035920.R23637-100000@gamplex.bde.org> ; from Bruce Evans <bde@zeta.org.au>  "Thu, 24 Oct 2002 04:00:32 +1000."
Date: Wed, 23 Oct 2002 19:56:17 +0100
From: Mark Murray <mark@grondar.za>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

> >   Make the first argument of getbsize a size_t* instead of an int*, as this is what the quantity actually is. Fix an easy const while I'm here.
> 
> This breaks binary compatibility on 64-bit machines.

So we perhaps need to bump ${MAJ}?

Consumers of this interface == { df, du, ls, pkg_install, stat, pstat }

Of the N (<12) calls to the function, 6 of them (one of 2 in df, stat, 3
in pstat) actually use the returned value. Easy fixes (warnings only).

I don't believe this is a crisis. Make world has fixed worse problems.

M
-- 
o       Mark Murray
\_
O.\_    Warning: this .sig is umop ap!sdn

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message