From owner-svn-src-all@FreeBSD.ORG  Sat Mar 12 19:57:30 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9E18A1065676;
	Sat, 12 Mar 2011 19:57:30 +0000 (UTC)
	(envelope-from alexander@leidinger.net)
Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de
	[217.11.53.44])
	by mx1.freebsd.org (Postfix) with ESMTP id 5711C8FC19;
	Sat, 12 Mar 2011 19:57:30 +0000 (UTC)
Received: from outgoing.leidinger.net (p5B15640F.dip.t-dialin.net
	[91.21.100.15])
	by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 57304844015;
	Sat, 12 Mar 2011 20:57:24 +0100 (CET)
Received: from unknown (IO.Leidinger.net [192.168.2.110])
	by outgoing.leidinger.net (Postfix) with ESMTP id 98E4F2A08;
	Sat, 12 Mar 2011 20:57:21 +0100 (CET)
Date: Sat, 12 Mar 2011 20:57:19 +0100
From: Alexander Leidinger <Alexander@Leidinger.net>
To: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <20110312205719.00004e67@unknown>
In-Reply-To: <201103120851.p2C8phoN010341@svn.freebsd.org>
References: <201103120851.p2C8phoN010341@svn.freebsd.org>
X-Mailer: Claws Mail 3.7.6 (GTK+ 2.16.0; i586-pc-mingw32msvc)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-EBL-MailScanner-Information: Please contact the ISP for more information
X-EBL-MailScanner-ID: 57304844015.A6CBA
X-EBL-MailScanner: Found to be clean
X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN,
	SpamAssassin (not cached, score=-0.923, required 6,
	autolearn=disabled, ALL_TRUSTED -1.00, TW_SV 0.08)
X-EBL-MailScanner-From: alexander@leidinger.net
X-EBL-MailScanner-Watermark: 1300564646.24487@fM88vG8FkygW2ekfPVd7ow
X-EBL-Spam-Status: No
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Artem Belevich <fbsdlist@src.cx>
Subject: Re: svn commit: r219559 - in head/sys: amd64/linux32
 compat/freebsd32 i386/linux kern
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Mar 2011 19:57:30 -0000

On Sat, 12 Mar 2011 08:51:43 +0000 (UTC) Andriy Gapon <avg@FreeBSD.org>
wrote:

> Author: avg
> Date: Sat Mar 12 08:51:43 2011
> New Revision: 219559
> URL: http://svn.freebsd.org/changeset/base/219559
> 
> Log:
>   add DTrace systrace support for linux32 and freebsd32 on amd64
> syscalls 
>   This commits makes necessary changes in syscall/sysent generation
>   infrastructure.

I assume this also includes syscall provider support for linux syscalls
on i386. Some questions below.

> Modified: head/sys/i386/linux/syscalls.master
> ==============================================================================
> --- head/sys/i386/linux/syscalls.master	Sat Mar 12 07:47:05 2011	(r219558)
> +++ head/sys/i386/linux/syscalls.master       Sat Mar 12 08:51:43 2011	(r219559)
> @@ -102,7 +102,7 @@
> 46	AUE_SETGID STD	{ int linux_setgid16(l_gid16_t gid); }
> 47	AUE_GETGID STD	{ int linux_getgid16(void); }
> 48	AUE_NULL STD	{ int linux_signal(l_int sig, \
> -				    l_handler_t handler); }
> +				    void *handler); }

What's wrong with l_handler_t?

> @@ -148,7 +148,7 @@
>  				    struct timeval *tp, \
>  				    struct timezone *tzp); }
>  79	AUE_SETTIMEOFDAY	NOPROTO	{ int
> settimeofday( \
> -				    struct timeval *tp, \
> +				    struct timeval *tv, \

What's wrong with tp?

Bye,
Alexander.