From owner-cvs-all@FreeBSD.ORG Fri Apr 20 14:34:54 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C73D716A400; Fri, 20 Apr 2007 14:34:54 +0000 (UTC) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id B85E413C44B; Fri, 20 Apr 2007 14:34:54 +0000 (UTC) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3KEYsnT022079; Fri, 20 Apr 2007 14:34:54 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3KEYsX1022078; Fri, 20 Apr 2007 14:34:54 GMT (envelope-from andre) Message-Id: <200704201434.l3KEYsX1022078@repoman.freebsd.org> From: Andre Oppermann Date: Fri, 20 Apr 2007 14:34:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet tcp_input.c tcp_syncache.c tcp_var.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2007 14:34:54 -0000 andre 2007-04-20 14:34:54 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c tcp_syncache.c tcp_var.h Log: Remove bogus check for accept queue length and associated failure handling from the incoming SYN handling section of tcp_input(). Enforcement of the accept queue limits is done by sonewconn() after the 3WHS is completed. It is not necessary to have an earlier check before a connection request enters the SYN cache awaiting the full handshake. It rather limits the effectiveness of the syncache by preventing legit and illegit connections from entering it and having them shaken out before we hit the real limit which may have vanished by then. Change return value of syncache_add() to void. No status communication is required. Revision Changes Path 1.338 +10 -16 src/sys/netinet/tcp_input.c 1.114 +2 -2 src/sys/netinet/tcp_syncache.c 1.143 +1 -1 src/sys/netinet/tcp_var.h