From owner-svn-src-all@freebsd.org Fri Aug 12 15:14:00 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1462EBB7549 for ; Fri, 12 Aug 2016 15:14:00 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D6C141E25 for ; Fri, 12 Aug 2016 15:13:59 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x231.google.com with SMTP id q83so27333353iod.1 for ; Fri, 12 Aug 2016 08:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=jyOtopTm7WQds9YgJIqtFVbAHlI8lHvS9RKglH7dWgY=; b=rHR2hLM1l0Wz70JRnDmGkUh5G3MliBjlnARbO+iwURw3RZzrWsTxdPI5IwNy9VFK7c sv6ZeUkJxYhv2qyM1eVmqm4t0hZjFvH918MPsQDZhFpHBk4qBKQ5Cm14/ZebN2RXLCMx gPoNMGvi+lY7qIUYK0jMY2EJCi5FC0zlO0oa2IXs1WgLJTq90BGEsFXp+yM43zxzOMv/ RUxE/+aYKonVQR2vcPUJUDuVHD+T5MS9Uu6L7JjXyyXyk6XEuIoKCRt0IRVLLvPMOy/K WhVdEDv9YU0F39Lw/mPeLXkkNNYBDLSslqsiMfzkM4el3zGDgjhgk0gF1SZMBci/ZN7v 0zYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=jyOtopTm7WQds9YgJIqtFVbAHlI8lHvS9RKglH7dWgY=; b=bcACKiP2Bko2+dMSLhjgH6mFVgkhYYqjEDnKkm0u6SlxgBeRTvTAOhAalYDWnWOt9W hQMJM9kQVyezga63MslEwnQ0M7smr+EkfZcuNUbTje9E3bhP+fU6M8R/UgiJ/8z3mrK0 zCSMWoAAvR2JZnxceVH5VmISxLneT1rDctp6BiQIk39O3H6TqBYJm6x17l+BvlRDLgEK J7b5/YWvYqEls0Ikbfj4ORQR0zX/2w4Sg45FSpGcPy/aFtHaWV/o9Idou+uR2Es2LEaz lWSufHN/yMKwDa8Kiok1q59RpHnNFq545JKi9sGeDblz+I9EjQFjnGZ1Mx1lDaMRiEZe I4IA== X-Gm-Message-State: AEkoouvRjU5NuJCPKTeX2gXQJROkgBs9+1u0kwpTVwCyQMtIwy643nJ2R3fqjj82qvXCj+H1QhGPb5kALJnlmA== X-Received: by 10.107.9.39 with SMTP id j39mr18415005ioi.73.1471014839249; Fri, 12 Aug 2016 08:13:59 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.36.65.105 with HTTP; Fri, 12 Aug 2016 08:13:58 -0700 (PDT) X-Originating-IP: [50.253.99.174] In-Reply-To: <20160812151117.GA52309@mithlond.kdm.org> References: <201607190536.u6J5aLl7015268@repo.freebsd.org> <3277576.dFZ2EGo2Fh@overcee.wemm.org> <6198652.UmU69kS6Zt@overcee.wemm.org> <181fcc35-3a5d-043f-7dc4-7a01a53eebae@FreeBSD.org> <7372bf93-69a2-f5f5-1d07-204fd31f252c@FreeBSD.org> <20160812151117.GA52309@mithlond.kdm.org> From: Warner Losh Date: Fri, 12 Aug 2016 09:13:58 -0600 X-Google-Sender-Auth: g75ZZPq3X_ggpmGxi7vH7mhRw5c Message-ID: Subject: Re: svn commit: r303019 - head/sys/geom To: "Kenneth D. Merry" Cc: "Andrey V. Elsukov" , Bryan Drewery , Peter Wemm , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , src-committers Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2016 15:14:00 -0000 On Fri, Aug 12, 2016 at 9:11 AM, Kenneth D. Merry wrote: > On Fri, Aug 12, 2016 at 13:38:21 +0300, Andrey V. Elsukov wrote: >> On 12.08.16 03:26, Bryan Drewery wrote: >> > On r303467 I ran into this: >> > >> > panic @ time 1470916206.652, thread 0xfffff8000412f000: >> > g_resize_provider_event but withered >> > cpuid = 0 >> > Panic occurred in module kernel loaded at 0xffffffff80200000: >> > >> > Stack: -------------------------------------------------- >> > kernel:kassert_panic+0x166 >> > kernel:g_resize_provider_event+0x181 >> > kernel:g_run_events+0x186^M^M >> > kernel:fork_exit+0x83^M^M >> > -------------------------------------------------- >> > >> > No further information available unfortunately. >> >> This one is related to r302087 :) > > It looks like there is a race. I think we need to replace the KASSERT > in g_resize_provider_event() with a return in case the provider is > withered. > > I won't be able to work on or test this until sometime next week. So if > you guys want to go ahead and make the change, please do. But why are we calling g_resize_provider on a withered object? That's the part I don't understand in this thread. Warner