From owner-freebsd-current@FreeBSD.ORG Fri Jul 2 10:21:49 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2811616A4CE; Fri, 2 Jul 2004 10:21:49 +0000 (GMT) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E56943D45; Fri, 2 Jul 2004 10:21:48 +0000 (GMT) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 12FDF1FFDDB; Fri, 2 Jul 2004 12:20:13 +0200 (CEST) Received: by transport.cksoft.de (Postfix, from userid 66) id 0F48B1FFDD9; Fri, 2 Jul 2004 12:20:11 +0200 (CEST) Received: by mail.int.zabbadoz.net (Postfix, from userid 1060) id B147D154DA; Fri, 2 Jul 2004 10:20:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.int.zabbadoz.net (Postfix) with ESMTP id A5391154BC; Fri, 2 Jul 2004 10:20:05 +0000 (UTC) Date: Fri, 2 Jul 2004 10:20:05 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@e0-0.zab2.int.zabbadoz.net To: Pawel Jakub Dawidek In-Reply-To: <20040702095721.GY12007@darkness.comp.waw.pl> Message-ID: References: <20040627101951.GJ12007@darkness.comp.waw.pl> <20040702095721.GY12007@darkness.comp.waw.pl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de cc: Robert Watson cc: FreeBSD current users cc: "Bjoern A. Zeeb" Subject: Re: jail getfsstat patches. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jul 2004 10:21:49 -0000 On Fri, 2 Jul 2004, Pawel Jakub Dawidek wrote: > On Fri, Jul 02, 2004 at 07:52:29AM +0000, Bjoern A. Zeeb wrote: > +> On Sun, 27 Jun 2004, Pawel Jakub Dawidek wrote: > +> > +> If you give me a few days (maybe I'll be ready today) I'll try to prepare > +> > +> patch to commit so we can review it together. > +> > > +> > Ok, here it goes: > +> > > +> > http://people.freebsd.org/~pjd/patches/jail_enforce_statfs.patch > +> > +> > +> in prison_canseemount shouldn't it be (pasted in by hand): > +> > +> * Be sure that we don't have situation where jail's root directory > +> * is "/some/path" and mount point is "/some/pathpath". > +> */ > +> - if (*sp->f_mntonname != '\0' && *sp->f_mntonname != '/') > +> + if (*(sp->f_mntonname+len) != '\0' && *(sp->f_mntonname+len) != '/') > +> return (ENOENT); > +> return (0); > > Yes, fixed, thanks! haven't re-fetched the patch but with above change things look good here on a production system (backported it to 5.2.1-pN and klded). To people who will backport: do not forget to also patch usr.sbin/jail what Pawel had done in HEAD already or make sure to not use symlinks or .. in the path given to jail(8). didn't review linux-compat or alpha and didn't test freebsd4_compat. many thanks for this work - great ! PS: spelling still left to someone else ;-) s/happend/happen/ -- Greetings Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT