From owner-cvs-all@FreeBSD.ORG Thu Mar 27 17:50:12 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A46BD37B401; Thu, 27 Mar 2003 17:50:12 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3EE5143FA3; Thu, 27 Mar 2003 17:50:12 -0800 (PST) (envelope-from jmallett@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h2S1oC0U033395; Thu, 27 Mar 2003 17:50:12 -0800 (PST) (envelope-from jmallett@repoman.freebsd.org) Received: (from jmallett@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h2S1oBq9033394; Thu, 27 Mar 2003 17:50:11 -0800 (PST) Message-Id: <200303280150.h2S1oBq9033394@repoman.freebsd.org> From: Juli Mallett Date: Thu, 27 Mar 2003 17:50:11 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD X-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) Subject: cvs commit: src/lib/libufs type.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Mar 2003 01:50:14 -0000 jmallett 2003/03/27 17:50:11 PST FreeBSD src repository Modified files: lib/libufs type.c Log: Close the disk file descriptor that is RO before trying to open the new one, and do not fall back to the RO fd. There was a bug here in that the RO fd was never closed, if the RDRW open succeeded, but this code is bogus anyway, and it breaks newfs of floppies, at least for me, due to "Device busy." Anything that wants to fall back is doing something significantly odd that it should have some more complex code on its end. Revision Changes Path 1.13 +1 -4 src/lib/libufs/type.c