From owner-freebsd-net@FreeBSD.ORG  Tue Mar  6 16:06:01 2007
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 0E3C716A403;
	Tue,  6 Mar 2007 16:06:01 +0000 (UTC)
	(envelope-from bms@incunabulum.net)
Received: from out5.smtp.messagingengine.com (out5.smtp.messagingengine.com
	[66.111.4.29])
	by mx1.freebsd.org (Postfix) with ESMTP id D60B213C46B;
	Tue,  6 Mar 2007 16:06:00 +0000 (UTC)
	(envelope-from bms@incunabulum.net)
Received: from out1.internal (unknown [10.202.2.149])
	by out1.messagingengine.com (Postfix) with ESMTP id 92EE21F49CC;
	Tue,  6 Mar 2007 11:06:00 -0500 (EST)
Received: from heartbeat2.messagingengine.com ([10.202.2.161])
	by out1.internal (MEProxy); Tue, 06 Mar 2007 11:06:00 -0500
X-Sasl-enc: v35MhDvnLGtsYkbOSQNGbFCO+OGmSJAg1j5vf+03uPxd 1173197160
Received: from [192.168.123.18]
	(82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254])
	by mail.messagingengine.com (Postfix) with ESMTP id AF216C9B4;
	Tue,  6 Mar 2007 11:05:58 -0500 (EST)
Message-ID: <45ED9165.5080406@incunabulum.net>
Date: Tue, 06 Mar 2007 16:05:57 +0000
From: Bruce M Simpson <bms@incunabulum.net>
User-Agent: Thunderbird 1.5.0.9 (X11/20070125)
MIME-Version: 1.0
To: Julian Elischer <julian@elischer.org>
References: <45E8B964.2090200@incunabulum.net>	<20070303215359.GB40430@comp.chem.msu.su>	<45EA0756.2000107@incunabulum.net>	<20070304070458.GG40430@comp.chem.msu.su>	<45EB750A.90105@incunabulum.net>	<20070305142411.GC57253@comp.chem.msu.su>
	<45EC2C37.7020604@incunabulum.net> <45EC9440.8060508@elischer.org>
In-Reply-To: <45EC9440.8060508@elischer.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Yar Tikhiy <yar@comp.chem.msu.su>, Kip Macy <kmacy@FreeBSD.org>,
	freebsd-net@freebsd.org
Subject: Re: [PATCH] Ethernet cleanup; 802.1p input and M_PROMISC
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Mar 2007 16:06:01 -0000

Julian Elischer wrote:
>
> When we added netgraph we split both the input and output parts
> so that they would provide 'natural' entrypoints for a bridge.
> Consider where a bridge wants to put packets.
In bms_netdev, bridge_input() is entered directly from ether_input(). It 
may potentially re-enter, so M_PROMISC is cleared on frames thus handed 
off to if_bridge(4). Same for ng_ether(4).
>
> Since the split however other code has made use of those entrypoints 
> at different
> times. I'm not sure at the moment whether other code does so now. 
According to KScope on -CURRENT, the only other places which call the 
split ether_demux() are dummynet_send() and ng_ether_rcv_upper().

Regards,
BMS