From owner-svn-src-head@freebsd.org Mon Aug 24 08:55:56 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9F9083B678B; Mon, 24 Aug 2020 08:55:56 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BZmDr3l8Pz4Pqv; Mon, 24 Aug 2020 08:55:56 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 63EF915DB9; Mon, 24 Aug 2020 08:55:56 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 07O8tuQt090591; Mon, 24 Aug 2020 08:55:56 GMT (envelope-from mjg@FreeBSD.org) Received: (from mjg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 07O8tup1090590; Mon, 24 Aug 2020 08:55:56 GMT (envelope-from mjg@FreeBSD.org) Message-Id: <202008240855.07O8tup1090590@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: mjg set sender to mjg@FreeBSD.org using -f From: Mateusz Guzik Date: Mon, 24 Aug 2020 08:55:56 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r364632 - head/sys/kern X-SVN-Group: head X-SVN-Commit-Author: mjg X-SVN-Commit-Paths: head/sys/kern X-SVN-Commit-Revision: 364632 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2020 08:55:56 -0000 Author: mjg Date: Mon Aug 24 08:55:55 2020 New Revision: 364632 URL: https://svnweb.freebsd.org/changeset/base/364632 Log: cache: perform reverse lookup using v_cache_dd if possible Tested by: pho Modified: head/sys/kern/vfs_cache.c Modified: head/sys/kern/vfs_cache.c ============================================================================== --- head/sys/kern/vfs_cache.c Mon Aug 24 08:55:04 2020 (r364631) +++ head/sys/kern/vfs_cache.c Mon Aug 24 08:55:55 2020 (r364632) @@ -2572,6 +2572,19 @@ vn_fullpath_global(struct thread *td, struct vnode *vn return (error); } +static struct namecache * +vn_dd_from_dst(struct vnode *vp) +{ + struct namecache *ncp; + + cache_assert_vnode_locked(vp); + TAILQ_FOREACH(ncp, &vp->v_cache_dst, nc_dst) { + if ((ncp->nc_flag & NCF_ISDOTDOT) == 0) + return (ncp); + } + return (NULL); +} + int vn_vptocnp(struct vnode **vp, struct ucred *cred, char *buf, size_t *buflen) { @@ -2582,9 +2595,13 @@ vn_vptocnp(struct vnode **vp, struct ucred *cred, char vlp = VP2VNODELOCK(*vp); mtx_lock(vlp); - TAILQ_FOREACH(ncp, &((*vp)->v_cache_dst), nc_dst) { - if ((ncp->nc_flag & NCF_ISDOTDOT) == 0) - break; + ncp = (*vp)->v_cache_dd; + if (ncp != NULL && (ncp->nc_flag & NCF_ISDOTDOT) == 0) { + KASSERT(ncp == vn_dd_from_dst(*vp), + ("%s: mismatch for dd entry (%p != %p)", __func__, + ncp, vn_dd_from_dst(*vp))); + } else { + ncp = vn_dd_from_dst(*vp); } if (ncp != NULL) { if (*buflen < ncp->nc_nlen) {