From owner-svn-src-head@freebsd.org Fri Oct 26 03:44:39 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D281E10D44E4 for ; Fri, 26 Oct 2018 03:44:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 680E580B9A for ; Fri, 26 Oct 2018 03:44:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x934.google.com with SMTP id g10so3266137uak.5 for ; Thu, 25 Oct 2018 20:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z07UUqUtx+4C7l+zkFUj6P9pKl/0f2MPnx+o4r6VGic=; b=WozOIfwGZV7O+MGqkT++k4lWzefQ34Fcx6ueQxYqla1J6VEyzn5TPI3k1yVKuntwvt UDJZLO9yYaZLup0/LAGXInxAfCUBPJukb42SmmTFqpEBR9fyw/Wq3yJDPawY3ryZ7RVm ISbj65nVzwgeXh3mWAGpwGUr8v3mFRoo8WtuHCi0raFEPE2nhx70m25fLncKAZM5Bdnl X0cpgsGDArtMdWJSyjKaLr2vQJK6741A3e/8hLrMM2eFLxt2n+95OPsggHDLJI7JDt8y 5uq/XbSmEymQ0DZ5zUtNQrgyus1bDDZ9NGNesGfv9REKTDCXAuzu8a/BE3HZRNieV8Sk msbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z07UUqUtx+4C7l+zkFUj6P9pKl/0f2MPnx+o4r6VGic=; b=lxQngC/f+CNiyR5UQzQHfuIvWwGFpfDi+dz3TO2xNUO4X2rYX8gJAdIGBrqKDsRJa2 SunGMUvHJXMqgOP1hi7LvK/G3QJh4EwxCULHBwz7400teiBWWOrb0pZW2cUsaiPSVidz qgqeLn9+7p3q21lsVW0kFZLyj6ODX9B4vG0Qw9NS1j567Xa/0LOPZmrVmc3CL/bR8Mzm udYu+oke87Os8Qp77B9id8STwI9RXX7yenhEcauwwrWIbVGtfYTZBHWJVD5HC71oel/V 8i01tZ+lzHgaXCy/bTzsDN5DbNCjFiTPRlqxXN7RRUycoX6l+lmAxYSmGQqJCqyX5gsF JgaA== X-Gm-Message-State: AGRZ1gL0NVM0X4bLur0fyDvNDpJiRjWqQb5sos2Atb1dZBI/ddqCeUX7 C3O63lY0flg8+mdWbFk6TOEElXzzXWzoUtHMsmBbJg== X-Google-Smtp-Source: AJdET5exTgU7rzKYFrzsAqbuBFZAT1+xNAJcgCn/hFxQCCLNPy0Yv4iG+inShscMrJ+3PFSJGgZJG8d7Or0DNeJXhcQ= X-Received: by 2002:ab0:53c3:: with SMTP id l3mr852760uaa.16.1540525477651; Thu, 25 Oct 2018 20:44:37 -0700 (PDT) MIME-Version: 1.0 References: <201810220234.w9M2Y0Wk043492@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Thu, 25 Oct 2018 21:44:24 -0600 Message-ID: Subject: Re: svn commit: r339563 - in head: . share/man/man4 sys/conf sys/dev/joy sys/modules sys/modules/joy sys/sys tools/kerneldoc/subsys To: Jan Beich Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 03:44:39 -0000 On Thu, Oct 25, 2018 at 9:30 PM Jan Beich wrote: > Warner Losh writes: > > > On Wed, Oct 24, 2018 at 9:42 AM Jan Beich wrote: > > > >> Warner Losh writes: > >> > >> > Author: imp > >> > Date: Mon Oct 22 02:34:00 2018 > >> > New Revision: 339563 > >> > URL: https://svnweb.freebsd.org/changeset/base/339563 > >> > > >> > Log: > >> > Remove joy(4) driver. > >> > > >> > This driver was marked as gone in 12. We're at 13 now. Remove it. > >> > Data from nycbug's dmesg cache shows only one potential user, > >> > suggesting it never was used much. > >> > > >> > RelNotes: yes > >> > Differential Revision: https://reviews.freebsd.org/D17629 > >> > >> Breaking userland API but not bothering with an exp-run or bumping > >> __FreeBSD_version. > >> Is the following the pointy hat you were looking for? > >> > >> > >> > https://forums.freebsd.org/threads/graphics-freeglut-fails-to-build-sys-joystick-h-not-found.68002/ > > > > > > Your tone is not acceptable. Please try again, only this time with the > > required level of professionalism. I'm not an idiot, and you will treat > me > > with respect. > > Apologies for the snide remark. I've expected someone with ports/ commit > bit > to be a bit more careful. > To be honest, I've never been burned before. It has been a learning lession. > > This driver was flagged for removal in 12 ages ago and the port failed to > > update to take that deprecation into account. > > Not sure what "ages ago" refers to when not even 1 year passed since > r328523. > Neither joy(4) manpage mentioned deprecation nor > __attribute__((deprecated)) > was used. Maintainers of consumers aren't necessarily joy(4) users. > But only joy(4) generates events and supports things described here. And joy(4) hasn't been relevant in this century. I thought this was totally safe. And I've not ever used / seen __attribute__((deprecated)). I will have to start using it. > Was joy(4) deprecation announced on the public mailing lists? For some > reason, > I can't easily find it in the archives. > I thought I had, but I'm not seeing it in my archives. > > You can use the bump to 1300000 as the version to fix it. I didn't bump > the > > revision because it wasn't needed. > > poudriere won't force rebuild everything if __FreeBSD_version doesn't > change. > Right. OK. I was not aware of that. > Expect silence from pkg-fallout@ until the next bump. > There was one earlier today. > > http://www.ipv6proxy.net/go.php?u=http://beefy12.nyi.freebsd.org/data/latest-per-pkg/sdl/1.2.15_12,2/head-amd64-default.log > > http://www.ipv6proxy.net/go.php?u=http://beefy12.nyi.freebsd.org/data/latest-per-pkg/plib/1.8.5_7/head-amd64-default.log > > vs. > > > http://beefy8.nyi.freebsd.org/data/latest-per-pkg/sdl/1.2.15_12,2/head-armv6-default.log > > http://beefy8.nyi.freebsd.org/data/latest-per-pkg/plib/1.8.5_7/head-armv6-default.log Yea, that's more extensive than I'd expected. > I posted a patch to the port that makes it compile for me to that thread. > > If there's confirmation that it works, i'll work with x11@freebsd.org to > > get it pushed in. Or just push it in myself since I'm on that list and > I'm > > a ports committer. > > https://codesearch.debian.net/search?q=sys/joystick.h could've been used > to guess a few consumers before pkg-fallout@ complains. > True. Most of them are bogus, but many are not. Given the number, I'm going to add sys/joystick.h back and bump the __FreeBSD_version and learn from my mistake. Warner