From owner-cvs-src@FreeBSD.ORG  Mon Jul  7 13:02:46 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 49F1137B401; Mon,  7 Jul 2003 13:02:46 -0700 (PDT)
Received: from frmug.org (frmug-gw.frmug.org [193.56.58.252])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 555A543F93; Mon,  7 Jul 2003 13:02:44 -0700 (PDT)
	(envelope-from charnier@xp11.frmug.org)
Received: from frmug.org (localhost [127.0.0.1])h67K2f0H020982NO);
	Mon, 7 Jul 2003 22:02:41 +0200 (CEST)
	(envelope-from charnier@xp11.frmug.org)
Received: (from uucp@localhost)
	by frmug.org (8.12.9/8.12.9/Submit) with UUCP id h67K2fS6020981;
	Mon, 7 Jul 2003 22:02:41 +0200 (CEST)
Received: from xp11.frmug.org (localhost [127.0.0.1])h67K3fuu051687;
	Mon, 7 Jul 2003 22:03:41 +0200 (CEST)
	(envelope-from charnier@xp11.frmug.org)
Message-Id: <200307072003.h67K3fuu051687@xp11.frmug.org>
To: Garance A Drosihn <drosih@rpi.edu>
In-Reply-To: Message from Garance A Drosihn <drosih@rpi.edu> 
	<p05210652bb2f55fc4c53@[128.113.24.47]> 
Date: Mon, 07 Jul 2003 22:03:41 +0200
From: "Philippe Charnier" <charnier@xp11.frmug.org>
cc: src-committers@FreeBSD.org
cc: Bruce Evans <bde@zeta.org.au>
cc: cvs-src@FreeBSD.org
cc: Alfred Perlstein <bright@mu.org>
cc: obrien@FreeBSD.org
cc: Philippe Charnier <charnier@FreeBSD.org>
Subject: Re: cvs commit: src/usr.sbin/lpr/lpd lpd.c ... 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jul 2003 20:02:46 -0000

Salut,

Garance A Drosihn <drosih@rpi.edu> wrote:

>I'm willing to go with the above for the sources in lpr if it
>is reasonable to everyone.  It's not quite what I want, but I
>probably should do something along these lines.
>
>Actually, let me take that a step further. How about I change
>all the source files to have:
>
>#include "lpr_cdefs.h"
>__FBSDID("$FreeBSD$");
>
[...]
>(note that I sometimes still compile lpr on an older release
>of freebsd, old enough that it does not have __FBSDID in it)
>
>That's probably a little ugly, but I could use it to get all of
>lpr using __FBSDID() so other developers will not feel tempted
>to add it "for me".  And, all the ugliness is off in the one
>lpr_cdefs.h file.  The nice thing about this for me is that
>I *might* even be able to use the "#ident" directive when
>compiling under IRIX, and I'll only have to change one file to
>do that.

Then we should be tempted to also add a crude hack for those OS that
do not have err() family functions, making porting easier. I think
that dealing with FBSDID is really the fastest stage of porting BSD
userland to other OS.

sys/cdefs.h seems to propose STRIP_FBSDID

------                                                            ------ 
Philippe Charnier          charnier@{xp11.frmug.org,free.fr,FreeBSD.org}

    ``a PC not running FreeBSD is like a venusian with no tentacles'' 
------------------------------------------------------------------------