From owner-svn-ports-all@FreeBSD.ORG  Wed Jan 21 13:49:41 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 569824FE;
 Wed, 21 Jan 2015 13:49:41 +0000 (UTC)
Received: from mail-we0-x22e.google.com (mail-we0-x22e.google.com
 [IPv6:2a00:1450:400c:c03::22e])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id E823C288;
 Wed, 21 Jan 2015 13:49:40 +0000 (UTC)
Received: by mail-we0-f174.google.com with SMTP id x3so9674000wes.5;
 Wed, 21 Jan 2015 05:49:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=sender:date:from:to:cc:subject:message-id:mail-followup-to
 :references:mime-version:content-type:content-disposition
 :in-reply-to:user-agent;
 bh=Maa0EdfHluuT64xi2PvjXnVHJVq5a2PIaFi7mHXHM5w=;
 b=GwHxKHmVieBHHCwAGNQ+t1A713/UFhUnsGJPIyoCkFHX7i0atIIUrmtPTAwJN8ZMHW
 I6EZVQoJXK90AFndeLzFbBR+GIRVFUhKv7DDgncE8Us5zbHARysLqYjlPjkwWGRrNQ2q
 xcoc+FHkVeUm3CNfczaaWwLlybY0WFtp2bmeADvuRJQxAAA1TT/fTpkdmJBrZSfWjxnl
 O3Q46itpYgWmiqbDjxUXae2+Dop3j847CPew1+g8abth2airvsHJH5+9eMSrJAsEuQC+
 gnxiqXBT5yq1MfuMZQeTowh3OdRTwr7G2CCYom3ivocBY2kuHPgBMAYPcZZhazBLQOq4
 j0nQ==
X-Received: by 10.194.192.4 with SMTP id hc4mr26220831wjc.59.1421848179273;
 Wed, 21 Jan 2015 05:49:39 -0800 (PST)
Received: from brick (abwu16.neoplus.adsl.tpnet.pl. [83.8.244.16])
 by mx.google.com with ESMTPSA id be2sm25614910wjb.38.2015.01.21.05.49.37
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 21 Jan 2015 05:49:38 -0800 (PST)
Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= <etnapierala@gmail.com>
Date: Wed, 21 Jan 2015 14:49:35 +0100
From: Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= <trasz@FreeBSD.org>
To: Koop Mast <kwm@rainbow-runner.nl>
Subject: Re: svn commit: r377068 - in head/devel: . gnu-efi gnu-efi/files
Message-ID: <20150121134935.GA6840@brick>
Mail-Followup-To: Koop Mast <kwm@rainbow-runner.nl>,
 ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
References: <201501150955.t0F9tvlO075446@svn.freebsd.org>
 <54B78FEE.4020705@rainbow-runner.nl>
 <20150115101118.GA3203@pc5.home>
 <54B795F4.2070308@rainbow-runner.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54B795F4.2070308@rainbow-runner.nl>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Jan 2015 13:49:41 -0000

On 0115T1127, Koop Mast wrote:
> On 15-1-2015 11:11, Edward Tomasz Napierala wrote:
> > On 0115T1101, Koop Mast wrote:
> >> On 15-1-2015 10:55, Edward Tomasz Napierala wrote:
> >>> Author: trasz
> >>> Date: Thu Jan 15 09:55:56 2015
> >>> New Revision: 377068
> >>> URL: https://svnweb.freebsd.org/changeset/ports/377068
> >>> QAT: https://qat.redports.org/buildarchive/r377068/
> >>>
> >>> Log:
> >>>    New port: devel/gnu-efi
> > [..]
> >
> >>> + # Compilation tools
> >>> +-HOSTCC       := $(prefix)gcc
> >>> +-CC           := $(prefix)$(CROSS_COMPILE)gcc
> >>> ++HOSTCC       := $(prefix)gcc48
> >>> ++CC           := $(prefix)$(CROSS_COMPILE)gcc48
> >>> + AS           := $(prefix)$(CROSS_COMPILE)as
> >>> + LD           := $(prefix)$(CROSS_COMPILE)ld
> >>> + AR           := $(prefix)$(CROSS_COMPILE)ar
> >>>
> >> This doesn't look right. In the Makefile your set USE_GCC=4.8+, so
> >> gcc 4.9 could be used. So these lines need to be adapted to that into
> >> account.
> > Hm, you're right.  What's the suggested way - force 4.8, or somehow
> > make the diff above adapt to GCC version?
> >
> >
> 
> What about this patch? [1]:
> USE_GCC will set ${CC} for us, we just use sed to add it to 
> Make.defaults. Bonus points is that when lang/gcc is bumped to a newer 
> version we don't have to fix the makefile anymore.
> I also think USE_GCC=yes can be used since lang/gcc is 4.8, which is the 
> default gcc port.

Committed, thanks!  I've also fixed sysutils/shim in the same way.