From owner-freebsd-net@FreeBSD.ORG Wed Sep 5 22:14:50 2007 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F0A316A419 for ; Wed, 5 Sep 2007 22:14:50 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.184]) by mx1.freebsd.org (Postfix) with ESMTP id 2CC5213C459 for ; Wed, 5 Sep 2007 22:14:49 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by nf-out-0910.google.com with SMTP id k4so1814440nfd for ; Wed, 05 Sep 2007 15:14:48 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=tO29ecvkE8cvbr9CagT/dEq3iymKZQH6SfhesZHjkI1gUtzbI00Bw+5pGcjO5KxYmMdKEjmxRRvNUDGWrqbpYMYsD0zqgP976cbMJn7EUwK80XT4qNCe0Hdw4f+5M4T6aTmI5UVC5eVuq1NDWC2LSGVNCl6xGuUsvfiZ7G9FtpU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=C4Un4B8gZ/90ZlA6agm3jdjoLx6EXOyC7DFbj50293/iMkRXLnlg7vlViLn43KRsnfELiuWDmCwqgg9OGUuKc/sRKo23kPNBD2zjwrdT2qmdj7K3wjYt0VO+NvSBqSPjrdIr8qUV/zJ68Rfo4tPuNVM6q39+v/roRX215TVoZKQ= Received: by 10.86.57.9 with SMTP id f9mr48838fga.1189030488586; Wed, 05 Sep 2007 15:14:48 -0700 (PDT) Received: by 10.86.81.6 with HTTP; Wed, 5 Sep 2007 15:14:48 -0700 (PDT) Message-ID: <2a41acea0709051514k3b72c932ya7b2e9bcb46a9c70@mail.gmail.com> Date: Wed, 5 Sep 2007 15:14:48 -0700 From: "Jack Vogel" To: "Scott Long" In-Reply-To: <46DF2119.6030909@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <2a41acea0709051352n583b4724o359faaf29a1479d8@mail.gmail.com> <46DF2119.6030909@samsco.org> Cc: "freebsd-net@freebsd.org" , Andre Oppermann , John Baldwin Subject: Re: Thoughts on vlan filter X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Sep 2007 22:14:50 -0000 On 9/5/07, Scott Long wrote: > Jack Vogel wrote: > > I had an idea, I was debugging a problem on my new 10G driver a week back, > > and found I had the hardware vlan filter enabled by accident, this led me to > > wonder about supporting this hardware feature in the driver... > > > > I have done some experimentation, and find that when the vlan device is > > configured, ultimately the SETMULTI ioctl will happen in my driver, this > > means I could add code that checks the trunk, finds there is a vlan and > > then sets the tag into the filter. > > > > Any interest, or thoughts ya or nay about my doing this? > > > > Cheers, > > > > Jack > > Overloading the SETMULTI ioctl is probably a bad idea for anything more > than a proof-of-concept. From a cleanliness point of view, making the > software vlan module aware of this as a hardware offload capability and > able to control it via new ioctls sounds more reasonable. > > Scott > > You're right, that would be ideal, so is there any other adapters with this capability, and is the vlan driver owner interested in implementing it? Jack