From owner-freebsd-hackers@freebsd.org  Sat Aug 15 20:05:04 2020
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id ABF4937D2A7
 for <freebsd-hackers@mailman.nyi.freebsd.org>;
 Sat, 15 Aug 2020 20:05:04 +0000 (UTC)
 (envelope-from wojtek@puchar.net)
Received: from puchar.net (puchar.net [194.1.144.90])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4BTWW41YLCz4gfC;
 Sat, 15 Aug 2020 20:05:03 +0000 (UTC)
 (envelope-from wojtek@puchar.net)
Received: Received: from 127.0.0.1 (localhost [127.0.0.1])
 by puchar.net (8.15.2/8.15.2) with ESMTPS id 07FK4wFM082082
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sat, 15 Aug 2020 22:04:58 +0200 (CEST)
 (envelope-from puchar-wojtek@puchar.net)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=puchar.net;
 s=default; t=1597521899;
 bh=fEJpA9HNWbetj+MnLk9SurI2QCzG7YQ3J8MORY4VPwU=;
 h=Date:From:To:cc:Subject:In-Reply-To:References;
 b=lnaYMQuqWTBPDE0kjC9Zzkg54ztq+/5hxY0xyR02hHScZOIMhEZJGxteHJkX3KSAb
 1JAaFezdiVibwL7/DDIinZaw3TQDA4qGKKEyM1VoizHhRz7JBh8fHefXKGIWC4S0o5
 dek8zeaBsxQ4ddKhWNZkjsd9iUJNDIO9rIiyT3Ho=
Received: from localhost (puchar-wojtek@localhost)
 by puchar.net (8.15.2/8.15.2/Submit) with ESMTP id 07FK4wU2082078;
 Sat, 15 Aug 2020 22:04:58 +0200 (CEST)
 (envelope-from puchar-wojtek@puchar.net)
Date: Sat, 15 Aug 2020 22:04:58 +0200 (CEST)
From: Wojciech Puchar <wojtek@puchar.net>
To: Mark Johnston <markj@freebsd.org>
cc: Wojciech Puchar <wojtek@puchar.net>, freebsd-hackers@freebsd.org
Subject: Re: gmirror balance model "prefer" doesnt work properly
In-Reply-To: <20200815165438.GA41502@raichu>
Message-ID: <alpine.BSF.2.20.2008152204200.81858@puchar.net>
References: <alpine.BSF.2.20.2008151127420.18876@puchar.net>
 <20200815165438.GA41502@raichu>
User-Agent: Alpine 2.20 (BSF 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
X-Rspamd-Queue-Id: 4BTWW41YLCz4gfC
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[];
 ASN(0.00)[asn:43476, ipnet:194.1.144.0/24, country:PL]
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Aug 2020 20:05:04 -0000

>>          LIST_FOREACH(disk, &sc->sc_disks, d_next) {
>>                  if (disk->d_state == G_MIRROR_DISK_STATE_ACTIVE)
>>                          break;
>>          }
>>
>>
>> just take first active disk.
>>
>> why?
>
> The highest priority disk is supposed to be first in the list.  However,
> the list is only sorted once the mirror is started, which is arguably

But is "higher priority" higher or lower number?


> the bug.  If you restart the mirror after adjusting the disk priorities,
> I'd expect the "prefer" algorithm to work properly.
>
>