From nobody Fri Sep 5 22:07:39 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cJVp517gGz66Tl7; Fri, 05 Sep 2025 22:07:41 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cJVp50Hq1z3qvS; Fri, 05 Sep 2025 22:07:41 +0000 (UTC) (envelope-from cperciva@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757110061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+T+cQZs8TviIQtcyUHpvMcUhaotFBTRVfEzucV25Vxc=; b=FmQh/H8/DGtBBsWjhGeGy3O/h6+L1mQ8mmX6KE9mlyBPuhukM4rBYCgwocMAv9YgHkG63G Q9MB5ZUN0BIW2lhOT0hotB43HPjzxI8PFZrGdMAdYpZhdj80RrNyDbYQMiivk/zF/3g90C QKPuuTIDiTOaRPVCDLmcOuGL9Or0BrP/wnkKOgvfxH+3wyagCidBpLYxig9lqldMMLm8ye /AR1I//gRnOgLzbbCGTcua9u1v72uCWQEnneVY7GyrXRcyUaLYtwq9mDWakTDruibdUpRx l5YuivN+rHU4PkcU3jWG6m9UMTqaYYLZ8tKmT0HNG/pbaTj/qEWbwFxxTW+ixg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757110061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+T+cQZs8TviIQtcyUHpvMcUhaotFBTRVfEzucV25Vxc=; b=ThMx54Z35IaNuy8hPpqpmcbgknojf9/jwrYDrpfO+ZiX1OzaYlWcpPriZ774I+ulpsR2a9 HBulxJw5aQNECGfQszETeZg6wqfTsPUTH9V1H3vLoAB1dVBHxd7b3xRxtrzGXhWH52cY83 BbJNKLATnWHn8+kYx3CTOWWFRWaa6Ypf3156RLlF+qTmQmUteujdJtUuPYcOnaPAfqSZvd H6rK/6yBhBTYlqZNmHK7kPTzCC0fkT0dhy1rUoEhmfHLrwygmQ9OS8a4QMADv8MzmaUt0b 7j43S0W6cKEj5iDbUkTZXOjoDoT20nnxYyCDxBcNDS7GgYQoowS2SxoLf41M8Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757110061; a=rsa-sha256; cv=none; b=a4hvY65qguQ2Jg8xlr9H3V1XMGDnqQWRxB8w+rqlQPr2D14B81uJapVn1A8Uu5W+2Rws6h rXApFN5FqKoleHTyenvQrfS3AwLiN85lIiJoxXIcghjafsz1XW+K6sPKY85dYXWDNFJJGY SkRtFX4fRX31ApJtU2x8n8QCAy9jcPHXrBWJJ5SLJB7uG/u8GzsaIUmx6nrj7vWCLguMIl vuSYA49uXNUU+mxKCYRPUsOPCRPQnkmm7fsIhQaRTpSzjRteEZpvKPIxZ4yxPNHYaH0VUA 25KJFJkXeo1FShojDE5fWo+V7nkX+7fVA9Ymlve77Oce0EC7DlMCJeEOsBDCbA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [192.168.6.36] (S0106684a76304d01.vf.shawcable.net [70.69.240.84]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: cperciva/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cJVp43FFzz1BH3; Fri, 05 Sep 2025 22:07:40 +0000 (UTC) (envelope-from cperciva@freebsd.org) Message-ID: <61bbeec6-6784-4c17-ac14-c1f5f5b68366@freebsd.org> Date: Fri, 5 Sep 2025 15:07:39 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: af60084978a4 - main - Add description for WITH_PTHREADS_ASSERTIONS To: Nuno Teixeira Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202509052136.585La5mx020210@gitrepo.freebsd.org> Content-Language: en-US From: Colin Percival Autocrypt: addr=cperciva@freebsd.org; keydata= xsFNBGWMSrYBEACdWRqDn3B3SKO7IG0/fGHYtfs26f3Q5QeAcasy1fQLniwGQWn5rlILhbCD K/jdNoDm5Zxq20eqyffoDNObCjnHgg4tGANdi+RmDy+7CDpE789H8dss9y7Pt5DlGGAXQQnt hxush3EYS/Ctprd9UUL/lzOOLOU1aNtzB84tNrJBtcJmL7OYHfyTSNFxvedqJrrasejIQOLI t/DQ89BPzz+vsKHz7FJPXh3fsVkzLA00DJYcfkgxyABfJNA7U6yMwd4DVSdx/SsvfIDMVXnu UXCXswo106WPZbYGlZPpq0wW6iibtTerJix+8AeuwXvl9O1p8yESK4ErkIxCnmghTSz+pdzj z/6xBRkdDM9VdZ0r+CzsaNXMpDOzFuKyjaiYBdgCLljbDnXIHFcqXenrZ7Xwkm09g/M4uVSh pIUG2RYa6tsHSQoGCp3f2RZv1znfViKQFbbL83QjtPA20AhseZSYbHp1FPhXyy9J0wkGL16L e99g6gdGeIRE82BZjBjKGDkoyDPq+oDRSFl8NtzmIKy+cfz00nViqcTF4bREXEawFGhlpO0X O9q8mijI9iFB6zaPBiSdJGBL5ML5qLTNCl8Zlf4m1TBvmRTqF/lzMHVXHidDoUhpSh/y3AFZ 1KrYc27ztJQywDJPJPWPbtY8YhFLFs377gfP8WldsZjzp8nvoQARAQABzSVDb2xpbiBQZXJj aXZhbCA8Y3BlcmNpdmFARnJlZUJTRC5vcmc+wsGRBBMBCAA7FiEEglY7hNBiDtwN+4ZBOJfy 4i5lrT8FAmWMSrYCGwMICwkNCAwHCwMFFQoJCAsFFgMCAQACHgUCF4AACgkQOJfy4i5lrT++ ig/9GZKdN2fHSyrANKZX38ivd7IX2wAYouqH9DrQM94W8IciaDLmarN4Pl9mY+aucMwQUSyp uNtKOJwKqhVVaalF9Zw0sRMH4CJuvT7vKCtZ3q1Okb7soRvFte4d+vXhvPxCvBFDA5JzU7Lg DR5eqqcvF1dN1OuCq16pl0zCOSH/Jr5ToE3LM3Av1KBGcZD7ZSzHRWsFjV5AOUJKySuA3GwJ e/jASQcQ0YfCnru8ntLmYg/2SKvZFlfthZiCBnAppMt4n4BUAw3TDvf10HIDtdneejawcbLS gofLCvGqumwbZYAMKWrFzT4+7KQvr0pOw8QD7EbxnB4f9hQ7UiVF8qWsyKU3iv6b5JLhbS59 ooKRccyOvdMLcVJ0ZdpqoxrNv061ZUqLL5RiWjBlc1qjBnDxeg5oyM0rT8WLftdgvyH6RQt0 KWngumBAT5AT2DUYL8Uz1490cqfO9K4yEGZAJB9XRVX1g2IWTOjae+0g9ZII+h91UngFz+Rz aKDeseKBbCGDOFXx1TqKiHl2g255ZnUxKYTlucFtguv4gDGBgEk4G9JaEWBw1IWblcKhxH7L 2vWsUhvwghjIxHdO/RkeIeHvSp4YZxCJ7a3TaJLYAlwYopfTKVzNhcDY5h5syEuoHjyJCxXK SyoJYAVu8Yl2KUhvOtOmL1VZ6xyHnpdMRWKJZ5jOwU0EZYxKtgEQANYfgbtUMVnhjxDHhWLp g5kLHK3YW0TfJKzpXqDB7NiqxHofn4OcbZnVC3MKggcbs9o1/UtsjnlsG8550PfiYkDXvPiO RJwgbGs6MGIDK797C6cnBLQ8xwBa9SL4cl5iQFnhWmt6vwnJ+an/cm5JpYves3wL7jV09qU9 57hkHXEUcl38r4FssZzVcLKPUVTa3Un+QGRTGDGe/f4ctjMaqv0ZCM+l2ixPhf/vqESrfSLv V/+T3dmtUfXjazO3SABvsHwxgGuTTYOlKoPCaebr+BRdqm0xeIShoIlhvTI8y4clchqx/Uxg UG5X2kvU13k3DS3Q8uLE4Et9x1CcZT6WGgBZSR6R0WfD0SDnzufNnRWJ0dEPA2MtJHE7+85R Vi9j/IgZV+y5Ur+bnPkjDG1s2SVciX5v9HQ0oilcBhvx0j5lGE9hhurD9F+fCvkr4KdbCknE 6Y8ce8pCNBUoB/DqibJivOzTk9K9MGB5x0De5TerIrFiaw3/mQC9nGeO9dtE7wvDJetWeoTq 4BEaCzpufNqbkpOaTQILr4V6Gp7M6v97g83TVAwZntz/q8ptwuKQPZ2JaSFLZn7oWUpYXA5s +SIODFHLn6iMoYpBQskHQjnj4lEPJadl4qj+ZKA89iDAKsniyoFXsbJe2CPbMS1yzBxKZq6K D/jpt7BOnuHr/JrXABEBAAHCwXYEGAEIACAWIQSCVjuE0GIO3A37hkE4l/LiLmWtPwUCZYxK tgIbDAAKCRA4l/LiLmWtP3jmEACQrh9gWe8F1Tkw3m6VoHKwLc5he4tX3WpQa//soPO6iGG3 S3WPruQ46NrAaAojoOcKI9UONDO5rxG0ZTX53S+lu2EO47jbcLwOCjaEpjKpDRt9ZXBQE8Xl mtBE9Bp3W9gpjB1nE3KNM1mJYgsK0QdRpwwfh4pVgGpOj8j23I6MCK+v99zEBnpgCn2GX8W/ kctRXHqWwndHysOJtRP/zrl7dDaABF1f9efUl0LL3TD3GJ9VDz+DNOin/uK2a1hiJo8QzTRk PpfUQ2ebzDsrd1i/pOWkMSkdH+rEu4AGrXWtaBwrMyrGkL6Icb6yO+P9/z0W2wlgBf3P1YRt JPgQt/Dj3yvA/UnaV/QmuVQPjl13o24UnJGsZM8XGnNdfWBKkC1Q6VXC4QT+dyBHYH9MuE9d 6oGl8pFM1+cTfEfbM62/rRoPkF1yHMsI/903VxEvuUIKfhEZAVLFyHldooNxuchntHQP9y8J 8Ou9bWYQP7MnEn+kwSwrZkjurfPkan+xQvp6dDYnj3V0GwA5pprBMaB928VIDVOv+1PNQI3t Cvk5VPv/skq+TJRMHW7bFSt8PRa91cUf1FOLIz9APDiJOzXkwxUEHGV3zPSaUhs1JYjyBeGT wDAvtLUdjOnRhEUOwlnIrztmvyciutjJoVzKEEjj5WXnHk9L9kQ1bpAjkjTONw== In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/5/25 14:57, Nuno Teixeira wrote: > For people that turn off debug on main, should WITH_PTHREADS_ASSERTIONS be > turned off? > > e.g. > /etc/src.conf: > WITH_MALLOC_PRODUCTION=yes > WITHOUT_LLVM_ASSERTIONS=yes According to commit 642cd511028b running WITHOUT_PTHREADS_ASSERTIONS improves mutex performance by 5-18%. So yes if you want maximal performance on HEAD you should probably turn this off. Colin Percival > > Thanks, > > Colin Percival > escreveu > (sexta, 5/09/2025 à(s) 22:36): > > The branch main has been updated by cperciva: > > URL: https://cgit.FreeBSD.org/src/commit/? > id=af60084978a43632c5ab2d6e3aca41be7a658d8c commit/?id=af60084978a43632c5ab2d6e3aca41be7a658d8c> > > commit af60084978a43632c5ab2d6e3aca41be7a658d8c > Author:     Colin Percival > AuthorDate: 2025-09-05 21:29:51 +0000 > Commit:     Colin Percival > CommitDate: 2025-09-05 21:35:53 +0000 > >     Add description for WITH_PTHREADS_ASSERTIONS > >     This option is turned on by default in -CURRENT but will be turned off >     in 15-STABLE; this description will land in the src.conf(5) man page >     in that branch. > >     MFC after:      1 minute > --- >  tools/build/options/WITH_PTHREADS_ASSERTIONS | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/tools/build/options/WITH_PTHREADS_ASSERTIONS b/tools/build/ > options/WITH_PTHREADS_ASSERTIONS > new file mode 100644 > index 000000000000..03c15b76fb85 > --- /dev/null > +++ b/tools/build/options/WITH_PTHREADS_ASSERTIONS > @@ -0,0 +1 @@ > +Enable debugging assertions in pthreads library. > > > > -- > Nuno Teixeira > FreeBSD UNIX:     Web: https://FreeBSD.org FreeBSD.org> -- Colin Percival FreeBSD Release Engineering Lead & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid