From owner-freebsd-arch Thu Dec 20 10:51:28 2001 Delivered-To: freebsd-arch@freebsd.org Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by hub.freebsd.org (Postfix) with ESMTP id 8443237B431; Thu, 20 Dec 2001 10:50:25 -0800 (PST) Received: (from uucp@localhost) by sax.sax.de (8.9.3/8.9.3) with UUCP id TAA02125; Thu, 20 Dec 2001 19:50:20 +0100 (CET) Received: (from j@localhost) by uriah.heep.sax.de (8.11.6/8.11.6) id fBKIaI846300; Thu, 20 Dec 2001 19:36:18 +0100 (MET) (envelope-from j) Date: Thu, 20 Dec 2001 19:36:18 +0100 From: Joerg Wunsch To: Bruce Evans Cc: Ruslan Ermilov , developers@FreeBSD.org, arch@FreeBSD.org Subject: Re: cvs commit: src/sys/isa fd.c Message-ID: <20011220193618.B19756@uriah.heep.sax.de> Reply-To: Joerg Wunsch Mail-Followup-To: Joerg Wunsch , Bruce Evans , Ruslan Ermilov , developers@freebsd.org, arch@freebsd.org References: <20011219095119.B93645@sunbay.com> <20011220235518.V673-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011220235518.V673-100000@gamplex.bde.org>; from bde@zeta.org.au on Fri, Dec 21, 2001 at 12:11:13AM +1100 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG As Bruce Evans wrote: > > This is because _MACHINE_ARCH is a bogus define. > > True. It doesn't seem to be used for anything except to break > netgraph/ng_vjc.c in the same way as fd.c ... > > Then, the #if _MACHINE_ARCH == i386 becomes #if 1 == 1. > > Actually, it becomes `#if 0 == 0' 8-8. Then i vote to either drop the macros _MACHINE and _MACHINE_ARCH completely from /sys/*/include/param.h, or to provide a set of unique constants they will be defined to so they can actually be used in cpp comparisions. What does NetBSD do here? It would surprise me if they didn't have a method to distinguish between their various machines at the cpp level. -- cheers, J"org .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/ NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message