Date: Fri, 16 Nov 2018 10:35:52 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 232936] lang/scm fails to build with GCC 8 Message-ID: <bug-232936-7788-SMCNc3pDUh@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-232936-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-232936-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D232936 --- Comment #7 from Gerald Pfeifer <gerald@FreeBSD.org> --- (In reply to Tobias Kortkamp from comment #5) > I guess we can land this with maintainer timeout [Wednesday] Yes, please. This is the last PR blocking the update to GCC 8 as the default. > Should the CFLAGS hack be made conditional on the GCC version? > Not exactly sure how to add such a check though given that the port > uses USE_GCC=3Dany vs USE_GCC=3Dyes. USE_GCC=3Dany really only should make a difference on non-tier 1=20 architectures that still have the age old GCC 4.2 as a system compiler. Everywhere else it is the same as USE_GCC=3Dyes. Hence I would not start hacking around re CFLAGS, and in fact switch over to USE_GCC=3Dyes: Doesn't make a difference for nearly everyone and actually gets those lower tier architectures more on par using what those that are regularly tested/used, increasing the chance it'll actually build and work there, too. Thanks for your help with this, Tobias! --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-232936-7788-SMCNc3pDUh>