From owner-cvs-all@FreeBSD.ORG  Thu Jul 15 05:49:39 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 33C2916A4CF; Thu, 15 Jul 2004 05:49:39 +0000 (GMT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2A31543D1D; Thu, 15 Jul 2004 05:49:39 +0000 (GMT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 20D035C86D; Wed, 14 Jul 2004 22:49:39 -0700 (PDT)
Date: Wed, 14 Jul 2004 22:49:39 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Don Lewis <truckman@FreeBSD.org>
Message-ID: <20040715054939.GN95729@elvis.mu.org>
References: <200407150429.i6F4Tm6U037891@repoman.freebsd.org>
	<200407150546.i6F5k4mK026902@gw.catspoiler.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200407150546.i6F5k4mK026902@gw.catspoiler.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_shutdown.c vfs_subr.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jul 2004 05:49:39 -0000

* Don Lewis <truckman@FreeBSD.org> [040714 22:46] wrote:
> On 15 Jul, Alfred Perlstein wrote:
> > alfred      2004-07-15 04:29:48 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/kern             kern_shutdown.c vfs_subr.c 
> >   Log:
> >   Tidy up system shutdown.
> >   
> >   Revision  Changes    Path
> >   1.156     +13 -5     src/sys/kern/kern_shutdown.c
> >   1.511     +11 -1     src/sys/kern/vfs_subr.c
> 
> The message in sched_sync should refer to "vnodes remaining" since that
> is what it is counting.  "Syncer syncing disks" sounds somewhat
> redundant, since that is its only purpose.  Maybe "Syncer doing final
> sync" would be better if verbosity is desirable.

Noted.  I'll fix that.

> I'd prefer skipping the the final sync() in boot() if there are no dirty
> buffers, with a message something like "skipping final sync because no
> dirty buffers remain".

Diffs welcome!

-- 
- Alfred Perlstein
- Research Engineering Development Inc.
- email: bright@mu.org cell: 408-480-4684