From owner-freebsd-ports  Thu Oct 10 14: 5:29 2002
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2670437B401; Thu, 10 Oct 2002 14:05:28 -0700 (PDT)
Received: from obsecurity.dyndns.org (adsl-64-165-226-88.dsl.lsan03.pacbell.net [64.165.226.88])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 72FD943EB3; Thu, 10 Oct 2002 14:05:27 -0700 (PDT)
	(envelope-from kris@obsecurity.org)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id A792C66C7B; Thu, 10 Oct 2002 14:05:26 -0700 (PDT)
Date: Thu, 10 Oct 2002 14:05:26 -0700
From: Kris Kennaway <kris@obsecurity.org>
To: Neil Blakey-Milner <nbm@mithrandr.moria.org>
Cc: Kris Kennaway <kris@obsecurity.org>, ports@FreeBSD.org,
	eivind@FreeBSD.org
Subject: Re: Updated dialog-based config patches
Message-ID: <20021010210526.GA28349@xor.obsecurity.org>
References: <20020930062804.GA50001@xor.obsecurity.org> <20021006202120.GA96047@xor.obsecurity.org> <20021010132556.GA17714@mithrandr.moria.org> <20021010181035.GA19338@mithrandr.moria.org> <20021010205723.GA20541@mithrandr.moria.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="gKMricLos+KVdGMg"
Content-Disposition: inline
In-Reply-To: <20021010205723.GA20541@mithrandr.moria.org>
User-Agent: Mutt/1.4i
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org


--gKMricLos+KVdGMg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 10, 2002 at 10:57:23PM +0200, Neil Blakey-Milner wrote:

> for option in ${OPTIONSLIST}; do
> 	eval optiontype=\$OPTION_${option}_TYPE
> 	eval optiondefault=\$OPTION_${option}_DEFAULT
> 	eval optiondescription=\$OPTION_${option}_DESCRIPTION
> 	echo "Option $option is of type $optiontype"
> 	echo "Option $option is for: $optiondescription"
> 	case $optiontype in
> 	boolean)
> 		eval withvar=\${WITH_${option}}
> 		eval withoutvar=\${WITHOUT_${option}}
> 		if [ ! -z "${withvar}" ]; then
> 			optiondefault=on
> 		elif [ ! -z "${withoutvar}" ]; then
> 			optiondefault=off
> 		fi
> 		;;
> 	esac
> 	DEFOPTIONS="${DEFOPTIONS} $option \"$optiondescription\" $optiondefault"
> done

Wouldn't this logic (which reads in existing default option values)
have to be duplicated in every replacement script?  It seems to make
more sense to do it in bsd.port.mk.

Kris

--gKMricLos+KVdGMg
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iD8DBQE9peuWWry0BWjoQKURAhJhAKDVnn/IN3CoYr/2D3u1YIzXltUlwgCgqgSA
ZBFNvG73FP8dZK5qa8RSnzw=
=QFWu
-----END PGP SIGNATURE-----

--gKMricLos+KVdGMg--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message