From nobody Fri Nov 3 09:15:58 2023 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SMFVZ5fjVz50XGY for ; Fri, 3 Nov 2023 09:16:38 +0000 (UTC) (envelope-from yasu@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SMFVZ4xqRz3YSx; Fri, 3 Nov 2023 09:16:38 +0000 (UTC) (envelope-from yasu@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699002998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zt8jBbPxhwa05uU+RyB/No1aene6hycK7zFWgO31+f0=; b=HoQwh5+dAZr7odFqFRNChXFnmtAHzuaTLJhKEVe3Oe0MEt0dSYdrtANfWDzyIObHkbnQYe uG1bwLgwTtz+O4GWPSuKO2CXM8OdWW/cR4tEGB2crJWqvcJRKk3mV4U96Jk3XOuOUsSLr9 4hNi6HRKa9BfWECuCgFeFaVDjqQkZxJfgfA8ug1zPQ2XX1GJlUouiuMZNRDPk9+NpyB1b4 WKcQA73JyIAMVWy/8RPr2t82F18YvJi/VE3/MRMtmOf2Eimgbv80W8zQrGF95J7dkHo8Ml gZeFIOv3I6dlbPrjIlUA+SrzRfgcDErYbNLxKCyQ10m64mRJNyBWEMlGcvg6gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699002998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zt8jBbPxhwa05uU+RyB/No1aene6hycK7zFWgO31+f0=; b=o1ks1DJmi/hmObK7n+b+mXtLCOv/HdTMAw3x8Jf5/m8qJOy43Pz8pUvhi2sj6iEgo003tL x5XHIFj7u7hc0dbqRbxyVQL90PLRTEnxqs1Z2EdW2AMh0njZYpJLZ8P3KySJHgYn5c9qu7 orzqk+JIV1pb2ptKRC5oQfFqTlb4016SAh3ldrEvpbV2c8mhS6bk/2B3Ab2/S9C/UX9rMV lfoxcPbR4/Xr1R5x/GQ53PJMB25bAqeWY8lDRJSu1TxUHJSS/DooAneBDQa2iQyLz/0oHW CIxVSQM6vdn1bNQc8XGywgouYulfMxTfFaIE8m23bUbm6ycUP03updjyF/udEw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699002998; a=rsa-sha256; cv=none; b=q3d88VkTAL8sWU/0n476PrjwAk4MH3wFWDIQchwQu/rdZTwNGrhoIUNO8J2dM4S12UebAg kt6DNVwuWmthJcCR+YR5Udapc0pIQs0CxYqOePM8jcUFfrzxVtCvYQvKhGDaNJcfzyP7S6 v4n0kRt++zGsqlCQxzckZr+pG3MGIFnSwMVMGrtgfSlbmpZsDd8yKOOt08RMPQKaMDXYzr s9E73Id8gRQ8rWhwBP237W8Y9QtFwNlYaW7iiy2p5TD1TAvo0Q908Jd53qT3h7JcFi3x4e fsIdcEyBs/bbpqDeUzSUyNmhEDhbEryaAlK1Tt2998GOMkJyJBoJm61A7paY9w== Received: from localhost (unknown [IPv6:240b:11:220:fe00::174:11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: yasu/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SMFVY6lWzzlbQ; Fri, 3 Nov 2023 09:16:37 +0000 (UTC) (envelope-from yasu@FreeBSD.org) Date: Fri, 03 Nov 2023 18:15:58 +0900 (JST) Message-Id: <20231103.181558.155976036412011835.yasu@FreeBSD.org> To: freebsd-ports@freebsd.org Subject: Re: 'USES=shebangfix' doesn't work with samba ports From: Yasuhiro Kimura In-Reply-To: References: <20231101.194831.884534926634764408.yasu@FreeBSD.org> X-Mailer: Mew version 6.9 on Emacs 30.0.50 List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hello Makino-san, From: Tatsuki Makino Subject: Re: 'USES=shebangfix' doesn't work with samba ports Date: Fri, 3 Nov 2023 12:35:16 +0900 > Tatsuki Makino wrote on 2023/11/02 18:18: >> .include or .include exist before this line. >> I have a feeling that is the cause :) > > Assuming we knew the reason, we needed to investigate the reason in more depth. > samba4* started shebangfix with the following commit > > https://cgit.freebsd.org/ports/commit/net/samba41/Makefile?id=e58cdfad2027226c15de6ad3508575f0dc3095c4 > > It is written in a way that creates problems at this point. > However, there would have been no problem with this, as there is no reason to leave something that does not work for almost 10 years. > So, that being the case, I checked out Mk/Uses/shebangfix.mk and here is what I found. > > https://cgit.freebsd.org/ports/commit/Mk/Uses/shebangfix.mk?id=c8de8164cad00f45461b3ca801dcad4bd56b993e > > It is possible that side effects have occurred since this time. > > There may have been some other change to Mk/bsd.port.mk being read in two passes, but I have not looked into that. > > Regards. Thanks for investigation. I have submitted the patch fixing the issue to Bugzilla. Bug 274885 net/samba413 net/samba416: Make 'USES=shebangfix' work as is expected https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274885 Regards. --- Yasuhiro Kimura