From owner-freebsd-net Wed May 13 16:51:56 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id QAA18213 for freebsd-net-outgoing; Wed, 13 May 1998 16:51:56 -0700 (PDT) (envelope-from owner-freebsd-net@FreeBSD.ORG) Received: from coconut.itojun.org (root@coconut.itojun.org [210.160.95.97]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id QAA18207 for ; Wed, 13 May 1998 16:51:50 -0700 (PDT) (envelope-from itojun@itojun.org) Received: from localhost (itojun@localhost.itojun.org [127.0.0.1]) by coconut.itojun.org (8.8.8+3.0Wbeta12/3.6W) with ESMTP id IAA25227; Thu, 14 May 1998 08:51:42 +0900 (JST) To: "Matthew N. Dodd" cc: freebsd-net@FreeBSD.ORG In-reply-to: winter's message of Wed, 13 May 1998 15:24:36 -0400. X-Template-Reply-To: itojun@itojun.org X-Template-Return-Receipt-To: itojun@itojun.org X-PGP-Fingerprint: F8 24 B4 2C 8C 98 57 FD 90 5F B4 60 79 54 16 E2 Subject: Re: WIDE/KAMI IPv6 From: Jun-ichiro itojun Itoh Date: Thu, 14 May 1998 08:51:42 +0900 Message-ID: <25223.895103502@coconut.itojun.org> Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org >Ok, for kicks I've been reviewing the KAMI and INRIA IPv6 stuff and have a >few questions/comments on the KAMI code I've seen so far. >What kind of crack prompted the need to do this: >+ #ifdef INET6 >+ in6_ifattach(&sc->arpcom.ac_if, IN6_IFT_802, >+ (caddr_t)sc->arpcom.ac_enaddr, 0); >+ #endif /* INET6 */ >+ >in -every- 'supported' network driver's XXinit function. The above claim is not true. You'll need to have the above line in attach routine for *pccard* network drivers. For normal interfaces, in6_ifattach() is called from in6_ifattach_802(), which is called from ip6_init2() in sys/netinet6/ip6_input.c. >Is there any reason this code does not belong in ifattach() or >ether_ifattach()? in6_ifattach() must be called after *all* the initialization for the interface. If we can guarantee that ether_ifattach() is called in the very last part of xxattach(), we can bury in6_ifattach() call into ether_ifattach. At this moment there's no such guarantee so we have added in6_ifattach() into attach routine, for pccard network cards. itojun To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message